Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Developer Hub logo is displayed with layout issues when the back button of the browser is clicked #7301

Closed
ioanarusiczki opened this issue Jan 15, 2018 · 4 comments · Fixed by #7530

Comments

@ioanarusiczki
Copy link

commented Jan 15, 2018

Prerequisites:
User is logged in

Steps to reproduce:

  1. Load AMO page and click on Developer Hub
  2. Click on My Add-ons
  3. Return to the Developer Hub page by clicking the logo
  4. Click on the back button of the browser

Expected result:
The Logo is correctly displayed.

Actual result:
Two white rectangles are displayed on the logo.

Notes:
Reproduced on all AMO servers with FF57(Win 10).
Please note that after the first click of the mouse the rectangles are no longer there.

developer hub logo3

@eviljeff

This comment has been minimized.

Copy link
Member

commented Jan 18, 2018

It's just Firefox's UI for indicating selected links - you always get it when you click on a link and go back to that page (you'll see it on other links too). It just looks a little strange on this page because we have unusual styling on the link to have the "Add-on" positioned lower, overlapping "Developer Hub".

@wagnerand

This comment has been minimized.

Copy link
Member

commented Feb 7, 2018

Mentor: me

If this is your first contribution, please refer to https://wiki.mozilla.org/Add-ons/Contribute/Code on how to get started.

To fix this issue, you would want to add outline:none to the header links.

@SeanPrashad

This comment has been minimized.

Copy link
Contributor

commented Feb 9, 2018

Hi there, I'd like to help out with this bug if it's still available!

wagnerand added a commit that referenced this issue Feb 9, 2018
Fixes #7301: Add outline: none; to .site-title.prominent <a> tag
@wagnerand wagnerand added this to the 2018.02.15 milestone Feb 9, 2018
@ioanarusiczki

This comment has been minimized.

Copy link
Author

commented Feb 12, 2018

Verified fixed on AMO dev using FF58 (Win10). I also tested with some similar scenarios and I could no longer reproduce this issue.

dreptunghiuri

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.