New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme 'textcolor' is applied to toolbar text and icons in the browser while AMO preview is represented differently #9642

Closed
AlexandraMoga opened this Issue Oct 10, 2018 · 1 comment

Comments

@AlexandraMoga

AlexandraMoga commented Oct 10, 2018

STR:

  1. Log in to AMO
  2. Submit a new theme through the wizard
  3. Select a value for "Header area text and icons" and leave the other fields to their default status
  4. Observe the generated preview after the theme is submitted
  5. Approve and install the theme
  6. Compare the preview with the installed version

Actual result:
In the browser, the selected textcolor is also applied to toolbar area text and icons

Expected result:
AMO theme preview should match with the theme applied in the browser

Notes:

  • I'm inclined to believe that this is an issue with how Firefox is displaying the theme, but I wasn't completely sure
  • reproduced on all AMO servers with FF62, 60 ESR and Nightly 64, Win10x64

image

@AlexandraMoga

This comment has been minimized.

AlexandraMoga commented Nov 5, 2018

Verified fixed on AMO -dev with FF63, Win10x64

The textcolor value will now fallback to the toolbar elements if there is no specific toolbar_text set.
This was verified both for wizard and file submissions.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment