New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AttributeError: 'list' object has no attribute 'lower' in search API following bleach upgrade #9711

Closed
diox opened this Issue Oct 16, 2018 · 3 comments

Comments

Projects
None yet
1 participant
@diox
Member

diox commented Oct 16, 2018

https://sentry.prod.mozaws.net/operations/olympia-prod/issues/4833317/

AttributeError: 'list' object has no attribute 'lower'
(17 additional frame(s) were not displayed)
...
  File "olympia/addons/serializers.py", line 453, in get_theme_data
    theme_data = obj.persona.theme_data
  File "olympia/addons/models.py", line 1719, in theme_data
    if addon.description is not None
  File "olympia/translations/models.py", line 182, in __unicode__
    self.clean()
  File "olympia/translations/models.py", line 194, in clean
    cleaned = self.clean_localized_string()
  File "olympia/translations/models.py", line 207, in clean_localized_string
    return cleaner.clean(unicode(self.localized_string))

AttributeError: 'list' object has no attribute 'lower'

It started to appear after the October 11st push, which coincides with when we pushed bleach 3.0.x upgrade to production. I just saw it when importing a bunch of add-ons locally using the prod search API.

@diox

This comment has been minimized.

Member

diox commented Oct 16, 2018

Might be fixed in Bleach 3.0.1 or 3.0.2 which are in our repos but haven't yet it production.

@diox

This comment has been minimized.

Member

diox commented Oct 16, 2018

@diox

This comment has been minimized.

Member

diox commented Oct 17, 2018

It should be fixed by #9634 or #9664 - I'll close this as qa- and monitor the situation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment