Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RTL display issue on 'Create a New Theme' banner (Fixes #3509) #3512

Merged
merged 1 commit into from Sep 21, 2016

Conversation

Projects
None yet
3 participants
@atiqueahmedziad
Copy link
Contributor

commented Sep 14, 2016

Fixes #3509

Before

Before

After

after

@atiqueahmedziad

This comment has been minimized.

Copy link
Contributor Author

commented Sep 14, 2016

background-size: 50% auto, auto auto;
p {
width: 50%;
}

.html-rtl & {
background-position: 0% 65px, 100% 100%;

This comment has been minimized.

Copy link
@muffinresearch

muffinresearch Sep 21, 2016

Member

Looks like an errant unnecessary comma

This comment has been minimized.

Copy link
@muffinresearch

muffinresearch Sep 21, 2016

Member

Ah ignore that comment - it's because there's two backgrounds.

@muffinresearch

This comment has been minimized.

Copy link
Member

commented Sep 21, 2016

Test failure is unlrelated flakey test.

@muffinresearch

This comment has been minimized.

Copy link
Member

commented Sep 21, 2016

@atiqueahmedziad thanks for the patch, and your patience :)

lgtm r+

@muffinresearch muffinresearch merged commit 21ac1f7 into mozilla:master Sep 21, 2016

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
ci/circleci Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.