New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get rid of test_utils (bug 1090184) #366
Merged
magopian
merged 4 commits into
mozilla:master
from
magopian:1090184-get-rid-of-test-utils
Nov 27, 2014
Merged
Get rid of test_utils (bug 1090184) #366
magopian
merged 4 commits into
mozilla:master
from
magopian:1090184-get-rid-of-test-utils
Nov 27, 2014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My hero. |
magopian
force-pushed
the
1090184-get-rid-of-test-utils
branch
3 times, most recently
from
November 18, 2014 08:47
82e9131
to
2507477
Compare
magopian
force-pushed
the
1090184-get-rid-of-test-utils
branch
from
November 18, 2014 09:34
2507477
to
8c0e083
Compare
magopian
force-pushed
the
1090184-get-rid-of-test-utils
branch
from
November 18, 2014 15:09
613de48
to
276e670
Compare
magopian
force-pushed
the
1090184-get-rid-of-test-utils
branch
from
November 19, 2014 10:24
d984ef5
to
7105acc
Compare
magopian
changed the title
[WIP] Get rid of test_utils (bug 1090184)
Get rid of test_utils (bug 1090184)
Nov 19, 2014
@@ -79,6 +79,7 @@ class TestHasPerm(TestCase): | |||
fixtures = ['base/users', 'base/addon_3615'] | |||
|
|||
def setUp(self): | |||
super(TestHasPerm, self).setUp() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now, you're my super()
hero ❤️
Looking good so far, thanks! |
magopian
force-pushed
the
1090184-get-rid-of-test-utils
branch
from
November 27, 2014 15:58
7105acc
to
fe7cbd7
Compare
magopian
added a commit
that referenced
this pull request
Nov 27, 2014
Get rid of test_utils (bug 1090184)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bug 1090184
This is heavily inspired by https://github.com/mozilla/zamboni/pull/2681/files