Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect path to next path when user logs in #4143

Merged
merged 5 commits into from Dec 14, 2016

Conversation

Projects
None yet
3 participants
@vijeth-aradhya
Copy link
Contributor

commented Dec 13, 2016

Fixed #4112

If the user is already logged in, and tries to log in, then redirect to next path instead of error on user login

@vijeth-aradhya

This comment has been minimized.

Copy link
Contributor Author

commented Dec 13, 2016

@mstriemer The checks are showing wrong (failed) in tests that I updated. This is expected right?

@@ -23,7 +23,7 @@
{% endif %}
<p>
<label>
{{ _('Enter the following text confirm your decision: {slug}')|fe(slug=addon.slug) }}
{{ _('Enter the following text to confirm your decision: {slug}')|fe(slug=addon.slug) }}

This comment has been minimized.

Copy link
@mstriemer

mstriemer Dec 13, 2016

Member

I think this was included accidentally, can you remove it from this pull request, please?

It looks like you're working on the master branch. I'd suggest you work on a new branch for each change.

self.request.data = {'code': 'woah', 'state': 'some-blob'}
self.request.data = {
'code': 'foo',
'state': 'other-blob:{}'.format(base64.urlsafe_b64encode('/next')),

This comment has been minimized.

Copy link
@mstriemer

mstriemer Dec 13, 2016

Member

This still needs to be some-blob before the : or it will trigger a different error.

@mstriemer

This comment has been minimized.

Copy link
Member

commented Dec 13, 2016

I think CircleCI is failing for something unrelated today. I suggested a fix for the other test failure above.

GitHub has some documentation on the sort of workflow I'm suggesting. You'll need to get your master branch back to matching mozilla/addons-server first though, might want to wait until we get this code landed to do that.

@vijeth-aradhya

This comment has been minimized.

Copy link
Contributor Author

commented Dec 13, 2016

I have made the requested changes.
Um do you think I rebase and match with the current repo as well?

@mstriemer

This comment has been minimized.

Copy link
Member

commented Dec 14, 2016

I'll squash the commits when I merge this. I think there's a fix landed for the CircleCI failure so I'm going to go ahead and merge this. It should pass on master.

@mstriemer mstriemer merged commit 4ed377a into mozilla:master Dec 14, 2016

1 of 2 checks passed

ci/circleci Your tests failed on CircleCI
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mstriemer

This comment has been minimized.

Copy link
Member

commented Dec 14, 2016

Thanks for your work on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.