Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix missing space #4151

Merged
merged 3 commits into from Dec 16, 2016

Conversation

Projects
None yet
4 participants
@Spidersouris
Copy link
Contributor

commented Dec 16, 2016

No description provided.

@Spidersouris Spidersouris changed the title Update django.po fix missing space Dec 16, 2016

@EnTeQuAk

This comment has been minimized.

Copy link
Member

commented Dec 16, 2016

Thanks for the patch!

This isn't the perfect place to fix this though. It'd be better to change the string in the file where it got extracted from:

diff --git a/src/olympia/devhub/templates/devhub/addons/submit/done.html b/src/olympia/devhub/templates/devhub/addons/submit/done.html
index 7c2f7b97ef..8b506ce11b 100644
--- a/src/olympia/devhub/templates/devhub/addons/submit/done.html
+++ b/src/olympia/devhub/templates/devhub/addons/submit/done.html
@@ -34,7 +34,7 @@
 {% else %}
   <h3>{{ _("Version Signed") }}</h3>
   <p>
-    {{ _("You’re done! This version is signed and ready to for self-distribution."
+    {{ _("You’re done! This version is signed and ready to for self-distribution. "
          "You can download it by clicking the button below.") }}
   </p>
   <p>

if you're up for it feel free to submit an update for your PR. Once this lands we can re-run extraction to make sure it's being fixed / updated everywhere.

Spidersouris added some commits Dec 16, 2016

@Spidersouris

This comment has been minimized.

Copy link
Contributor Author

commented Dec 16, 2016

Alright, thanks. Done!

@EnTeQuAk

This comment has been minimized.

Copy link
Member

commented Dec 16, 2016

Wonderful, thanks! Let's wait for travis and then I'll merge it.

@EnTeQuAk EnTeQuAk self-assigned this Dec 16, 2016

@EnTeQuAk EnTeQuAk self-requested a review Dec 16, 2016

@EnTeQuAk EnTeQuAk merged commit 3f012f2 into mozilla:master Dec 16, 2016

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@caitmuenster

This comment has been minimized.

Copy link

commented Dec 16, 2016

Hey Spidersouris! Thanks so much for this fix. Your contribution has been added to our recognition wiki.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.