Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override Download button underline #4159

Merged
merged 1 commit into from Jan 3, 2017

Conversation

Projects
None yet
4 participants
@gamebusterz
Copy link
Contributor

commented Dec 20, 2016

Removed the underline from the Download button #2247

Override Download button underline
Removed the underline from the Download button
@EnTeQuAk

This comment has been minimized.

Copy link
Member

commented Dec 20, 2016

Thanks a lot for the patch @gamebusterz! This looks good so far, could you maybe add before / after screenshots to simplify the work of our QA to ensure it looks the way it's supposed to?

@EnTeQuAk EnTeQuAk self-requested a review Dec 20, 2016

@EnTeQuAk EnTeQuAk self-assigned this Dec 20, 2016

@gamebusterz

This comment has been minimized.

Copy link
Contributor Author

commented Dec 22, 2016

@EnTeQuAk I am facing some problem while doing that. I have olympia.dev up and running, and when I go to Other Applications > Android and search for 'Comics.com Search' , I get no matching results. Also, another thing I noticed was that the url of the page where the bug was pointed out was 'allizomand normally it's 'mozilla' . Searching onhttp://olympia.dev/en-US/android` I found no matching results to 'Comics.com Search'. Is there something I'm missing ?

@EnTeQuAk

This comment has been minimized.

Copy link
Member

commented Jan 3, 2017

Sorry @gamebusterz for the late reply but holidays and new years eve came in between.

You will have to setup an add-on on your local machine or create a bunch of it by running make initialize_docker: https://addons-server.readthedocs.io/en/latest/topics/install/docker.html#setting-up-the-containers

Otherwise, if you can apply your changes on the live-page by hooking into the developer tools and make a screenshot of that it'll be fine too. It's a rather small change.

@gamebusterz

This comment has been minimized.

Copy link
Contributor Author

commented Jan 3, 2017

Before
before

After
after

@EnTeQuAk

This comment has been minimized.

Copy link
Member

commented Jan 3, 2017

Perfect, thanks a lot for adding the screenshots!

@EnTeQuAk EnTeQuAk merged commit 72c9cc4 into mozilla:master Jan 3, 2017

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@caitmuenster

This comment has been minimized.

Copy link

commented Jan 3, 2017

Thanks, @gamebusterz! Your contribution has been added to our Recognition wiki.

Welcome onboard! We're happy to have you on the team.

@gamebusterz

This comment has been minimized.

Copy link
Contributor Author

commented Jan 3, 2017

Thank you @caitmuenster , @EnTeQuAk and @eviljeff for being so supportive and welcoming. Would love to keep making my contributions bigger and more significant. Thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.