Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed RTL issue for "Mobile Add-ons site" message banner #5671

Merged
merged 1 commit into from Jun 19, 2017

Conversation

Projects
None yet
5 participants
@ahmedhasan07
Copy link
Contributor

commented Jun 17, 2017

#4791 issue is fixed.

Before and after screenshot is attached.

Before
screen shot 2017-06-17 at 20 05 11
After
screen shot 2017-06-17 at 20 05 00

@ahmedhasan07

This comment has been minimized.

Copy link
Contributor Author

commented Jun 17, 2017

Thanks @atiqueahmedziad for helping 😄

@eviljeff
Copy link
Member

left a comment

thanks

@eviljeff eviljeff merged commit 51fccd1 into mozilla:master Jun 19, 2017

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@caitmuenster

This comment has been minimized.

Copy link

commented Jun 19, 2017

Thanks for the patch, @ahmedhasan07! Your contribution has been added to our recognition wiki and your Mozillians profile has been vouched. :)

Welcome onboard! I look forward to seeing you around!

@@ -566,6 +566,10 @@ body:not(.home) .amo-header,
margin-top: 22px;
padding: 15px 45px 15px 15px;

.html-rtl & {

This comment has been minimized.

Copy link
@atiqueahmedziad

atiqueahmedziad Jun 21, 2017

Contributor

There is a small typo/mistake. It should be .html-rtl& instead of .html-rtl &

This comment has been minimized.

Copy link
@eviljeff

eviljeff Jun 22, 2017

Member

can you create a pull request?

This comment has been minimized.

Copy link
@atiqueahmedziad

atiqueahmedziad Jun 22, 2017

Contributor

Sure. Here is the pr- #5740

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.