Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hard-codes the en-US locale in all links to MDN #5898

Merged
merged 3 commits into from Jul 20, 2017

Conversation

Projects
None yet
5 participants
@apoorvaeternity
Copy link
Contributor

commented Jul 12, 2017

Fixes #5897

@apoorvaeternity apoorvaeternity force-pushed the apoorvaeternity:issue_5897 branch from 5aeee5a to 942fbc2 Jul 12, 2017

@diox

This comment has been minimized.

Copy link
Member

commented Jul 12, 2017

Let's not merge until the discussion in the issue has been resolved.

@wagnerand
Copy link
Member

left a comment

@apoorvaeternity Thanks for this patch. There are a couple of more occurences throughout the repository, could you take care of them as well, please?

@apoorvaeternity

This comment has been minimized.

Copy link
Contributor Author

commented Jul 20, 2017

@wagnerand I have made changes in just the templates. Do I have to make this change in other files as well like views, tests, .po and .mo files?

@EnTeQuAk

This comment has been minimized.

Copy link
Member

commented Jul 20, 2017

@wagnerand I have made changes in just the templates. Do I have to make this change in other files as well like views, tests, .po and .mo files?

No, this looks great so far. .po files get extracted on a regular basis and there don't seem to be any tests failing so 👍

@wagnerand

This comment has been minimized.

Copy link
Member

commented Jul 20, 2017

@apoorvaeternity Thank you!

I see a couple of more instances:

src/olympia/amo/templates/amo/developer_agreement.html:57
src/olympia/amo/templates/amo/developer_agreement.html:87
src/olympia/amo/templates/amo/developer_agreement.html:116
src/olympia/devhub/templates/devhub/new-landing/components/overview.html:5
src/olympia/devhub/templates/devhub/search.html:1
src/olympia/devhub/views.py:69
static/js/common/upload-addon.js:459
@wagnerand
Copy link
Member

left a comment

Looks great, thanks again!

@wagnerand wagnerand merged commit 939eba1 into mozilla:master Jul 20, 2017

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.