Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I6099 : Support section in review box issue #6354

Merged
merged 2 commits into from Sep 8, 2017

Conversation

Projects
None yet
2 participants
@tsl143
Copy link
Contributor

commented Sep 7, 2017

Fixes #6099
(Refer hyperlinks in the screenshots)
Before:
screen shot 2017-09-07 at 9 14 23 pm

After:
screen shot 2017-09-07 at 9 10 24 pm

{% if addon.support_url %}
<a class="support" href="{{ addon.support_url|external_url }}">{{ _('support section') }}</a>
{% elif addon.support_email %}
{{ emaillink(addon.support_email.localized_string, _('support E-mail')) }}

This comment has been minimized.

Copy link
@EnTeQuAk

EnTeQuAk Sep 8, 2017

Member

Should be Support Email imho, or support email but not with the dash

Trishul Goel
@tsl143

This comment has been minimized.

Copy link
Contributor Author

commented Sep 8, 2017

@EnTeQuAk , I will go with small case so as to keep text in sync with support section

@EnTeQuAk EnTeQuAk merged commit 3ee3f3b into mozilla:master Sep 8, 2017

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@EnTeQuAk

This comment has been minimized.

Copy link
Member

commented Sep 8, 2017

Thanks a lot for your contribution, I merged this and it should go online next Thursday.

@tsl143

This comment has been minimized.

Copy link
Contributor Author

commented Sep 8, 2017

Awesome :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.