From 5998137545e64550448f17fa0458529b9b8443e1 Mon Sep 17 00:00:00 2001 From: Kris Maglione Date: Tue, 11 Aug 2015 13:45:24 -0700 Subject: [PATCH] Bug 1193137: Remove `commit_manually` decorator from app version update task. --- apps/addons/cron.py | 3 ++- apps/addons/tasks.py | 1 + 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/apps/addons/cron.py b/apps/addons/cron.py index bd1f9d278277..350543b66c17 100644 --- a/apps/addons/cron.py +++ b/apps/addons/cron.py @@ -252,6 +252,7 @@ def update_addon_appsupport(): ids = (Addon.objects.valid().distinct() .filter(newish, good).values_list('id', flat=True)) + task_log.info('Updating appsupport for %d new-ish addons.' % len(ids)) ts = [_update_appsupport.subtask(args=[chunk]) for chunk in chunked(ids, 20)] TaskSet(ts).apply_async() @@ -270,9 +271,9 @@ def update_all_appsupport(): @task -@transaction.commit_manually def _update_appsupport(ids, **kw): from .tasks import update_appsupport + task_log.info('Updating appsupport for %d of new-ish addons.' % len(ids)) update_appsupport(ids) diff --git a/apps/addons/tasks.py b/apps/addons/tasks.py index f2687afcd321..eb5d2b041e37 100644 --- a/apps/addons/tasks.py +++ b/apps/addons/tasks.py @@ -61,6 +61,7 @@ def update_last_updated(addon_id): Addon.objects.filter(pk=pk).update(last_updated=t) +@write def update_appsupport(ids): log.info("[%s@None] Updating appsupport for %s." % (len(ids), ids))