Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes the button label @ /developers/addon/submit/agreement more readable #6565

Merged
merged 2 commits into from Oct 4, 2017

Conversation

Projects
None yet
3 participants
@ilmanzo
Copy link
Contributor

commented Oct 2, 2017

Fixes #6400

@apoorvaeternity

This comment has been minimized.

Copy link
Contributor

commented Oct 3, 2017

@ilmanzo Please add screenshots of the page before the fix and after applying the fix.

@@ -36,7 +39,7 @@
{% csrf_token %}
<button id="accept-agreement" type="submit">
{% if waffle.switch('post-review') %}
{{ _('I have read and accept this Agreement and the Rules and Policies') }}
{{ _('Accept') }}

This comment has been minimized.

Copy link
@EnTeQuAk

EnTeQuAk Oct 4, 2017

Member

This unfortunately is less readable for people needing accessibility helpers that read buttons. Do you have a screenshot showing what the actual problem is here? Potentially that can be fixed with styling.

This comment has been minimized.

Copy link
@EnTeQuAk

EnTeQuAk Oct 4, 2017

Member

hmm, okay I noticed this got decided in #6400 so I think that's what we're going to do.

@EnTeQuAk
Copy link
Member

left a comment

I'll run an l10n extract after merging this.

Thanks for the pull request!

@EnTeQuAk EnTeQuAk merged commit d0c4147 into mozilla:master Oct 4, 2017

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.