Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #6235 - Change default sorting to be Updated on 'developers/addons' #6732

Merged
merged 2 commits into from Oct 19, 2017

Conversation

Projects
None yet
2 participants
@raajitr
Copy link
Contributor

commented Oct 19, 2017

Hi,
This fixes #6235.

I'm not sure changing the order of updated and name in opts was necassary, but I still did it.
Will change it if comes in review.

Thanks,

@diox

This comment has been minimized.

Copy link
Member

commented Oct 19, 2017

Thanks! I was about to comment about why the tests were broken but I see you figured out yourself and fixed them, that's perfect.

@diox diox merged commit ca8f6c3 into mozilla:master Oct 19, 2017

2 checks passed

ci/circleci: integration_test Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@raajitr

This comment has been minimized.

Copy link
Contributor Author

commented Oct 19, 2017

Yea, I forgot to run tests locally first.

Thanks!

@raajitr raajitr deleted the raajitr:default-to-update branch Oct 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.