Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unbroken strings in add-on name #8419

Merged
merged 1 commit into from Jun 5, 2018

Conversation

iamkhush
Copy link
Contributor

@iamkhush iamkhush commented Jun 2, 2018

Made css changes to overflow-wrap

  • This PR relates to an existing open issue and there are no existing
    PRs open for the same issue.
  • Add Fixes #ISSUENUM at the top of your PR.
  • Add a description of the the changes introduced in this PR.
  • The change has been successfully run locally.
  • Add tests to cover the changes added in this PR.
  • Add before and after screenshots (Only for changes that impact the UI).

Fix #8166
Before -
screenshot-2018-6-3 developer hub add-ons for firefox 1

After -
screenshot-2018-6-3 developer hub add-ons for firefox

@EnTeQuAk
Copy link
Contributor

EnTeQuAk commented Jun 5, 2018

Thank you so much for your pull request! Can you maybe attach a few screenshots that show your changes / fixes so that it's easier to review the pull request and for QA later to test the changes properly? That'd help us a lot!

@iamkhush
Copy link
Contributor Author

iamkhush commented Jun 5, 2018

@EnTeQuAk Done.

Copy link
Member

@eviljeff eviljeff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for the contribution.

@eviljeff eviljeff merged commit 7ca6600 into mozilla:master Jun 5, 2018
@caitmuenster
Copy link

Thank you, @iamkhush! 🎉Your contribution has been added to our recognition wiki and your Mozillians profile has been vouched for.

Welcome onboard! I look forward to seeing you around the project.

@iamkhush iamkhush deleted the fix-unbroken-strings branch June 5, 2018 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants