Making e-mail restrictions case insensitive #9426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diox
reviewed
Sep 14, 2018
src/olympia/users/utils.py
Outdated
| @@ -87,7 +87,7 @@ def autocreate_username(candidate, tries=1): | |||
|
|
|||
|
|
|||
| def system_addon_submission_allowed(user, parsed_addon_data): | |||
| guid = parsed_addon_data.get('guid') or '' | |||
| guid = parsed_addon_data.get('guid').lower() or '' | |||
There was a problem hiding this comment.
Can you make that parsed_addon_data.get('guid', '').lower() ? Need to handle the case where somehow guid is not present in parsed data (mainly for tests)
There was a problem hiding this comment.
Yeah, I realised that after seeing the failed tests.
Made a hotfix in a bit different way, is that one good or should I change to the method you mentioned?
There was a problem hiding this comment.
Perfect. Let's see if the tests pass now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9425
I made the assumption that GUID will have ASCII values since the
lower()function seems to break for some Greek characters.