Permalink
Browse files

clean up deprication warning and private browsing code

  • Loading branch information...
1 parent 65a10a9 commit 14059057fd6a8ec68ed7448f5331748c9c921b15 @wraithan wraithan committed Mar 21, 2013
Showing with 10 additions and 17 deletions.
  1. +1 −1 validator/rdf.py
  2. +9 −16 validator/testcases/regex.py
View
@@ -10,7 +10,7 @@ class RDFException(Exception):
def __init__(self, message=None, orig_exception=None):
if message is None and orig_exception is not None:
- message = orig_exception.message
+ message = orig_exception.getMessage()
super(RDFException, self).__init__(message)
self.orig_exception = orig_exception
@@ -855,23 +855,16 @@ class Gecko20RegexTests(CompatRegexTestHelper):
def js_tests(self):
- yield self.get_test_bug(
- 826079, "nsIPrivateBrowsingService",
- "`nsIPrivateBrowsingService` has been removed.",
- "`nsIPrivateBrowsingService` and its related observer "
- "notifications have been removed due to the new per-window "
- "private browsing mode. See {0} for more "
- "information.".format(self.PRIVATE_BROWSING_LINK),
- compat_type="error", log_function=self.err.notice)
- yield self.get_test_bug(
- 826079, "private-browsing",
- "`nsIPrivateBrowsingService` has been removed.",
- "`nsIPrivateBrowsingService` and its related observer "
- "notifications have been removed due to the new per-window "
- "private browsing mode. See {0} formore "
@cvan
cvan Mar 21, 2013 Member

there was even a typo that you fixed: "formore"

- "information.".format(self.PRIVATE_BROWSING_LINK),
- compat_type="error", log_function=self.err.notice)
+ for pbs in ("nsIPrivateBrowsingService", "private-browsing"):
+ yield self.get_test_bug(
+ 826079, pbs,
+ "`nsIPrivateBrowsingService` has been removed.",
+ "`nsIPrivateBrowsingService` and its related observer "
+ "notifications have been removed due to the new per-window "
+ "private browsing mode. See {0} for more "
+ "information.".format(self.PRIVATE_BROWSING_LINK),
+ compat_type="error", log_function=self.err.notice)
yield self.get_test_bug(
816362, "decodeImageData",

3 comments on commit 1405905

@cvan
Member
cvan commented on 1405905 Mar 21, 2013

but then you introduced another typo: "deprication"

@wraithan

I copy and pasted it from their message, I'll fix that.

@cvan
Member
cvan commented on 1405905 Mar 21, 2013

I copy and pasted it from their message, I'll fix that.

no I meant in the commit message. you're fine... it's fine...

Please sign in to comment.