Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

Flag DOMNSEditable (bug 852668)

  • Loading branch information...
commit 65a10a94c9bd1b5be05e749641481adbfc7a7497 1 parent 2b1daf4
@wraithan wraithan authored
Showing with 24 additions and 3 deletions.
  1. +7 −0 tests/compat/test_gecko20.py
  2. +17 −3 validator/testcases/regex.py
View
7 tests/compat/test_gecko20.py
@@ -27,3 +27,10 @@ def test_decode_image_data(self):
""")
self.assert_silent()
self.assert_compat_warning(type_="notice")
+
+ def test_decode_image_data(self):
+ self.run_script_for_compat("""
+ var x = nsIDOMNSEditableElement;
+ """)
+ self.assert_silent()
+ self.assert_compat_warning(type_="notice")
View
20 validator/testcases/regex.py
@@ -851,13 +851,14 @@ class Gecko20RegexTests(CompatRegexTestHelper):
VERSION = FX20_DEFINITION
PRIVATE_BROWSING_LINK = "https://developer.mozilla.org/en-US/docs/Updating_addons_broken_by_private_browsing_changes"
DECODE_LINK = "https://bugzilla.mozilla.org/show_bug.cgi?id=816362"
+ EDITABLE_LINK = "https://bugzilla.mozilla.org/show_bug.cgi?id=827546"
def js_tests(self):
yield self.get_test_bug(
826079, "nsIPrivateBrowsingService",
"`nsIPrivateBrowsingService` has been removed.",
- "nsIPrivateBrowsingService and its related observer "
+ "`nsIPrivateBrowsingService` and its related observer "
"notifications have been removed due to the new per-window "
"private browsing mode. See {0} for more "
"information.".format(self.PRIVATE_BROWSING_LINK),
@@ -866,7 +867,7 @@ def js_tests(self):
yield self.get_test_bug(
826079, "private-browsing",
"`nsIPrivateBrowsingService` has been removed.",
- "nsIPrivateBrowsingService and its related observer "
+ "`nsIPrivateBrowsingService` and its related observer "
"notifications have been removed due to the new per-window "
"private browsing mode. See {0} formore "
"information.".format(self.PRIVATE_BROWSING_LINK),
@@ -874,12 +875,25 @@ def js_tests(self):
yield self.get_test_bug(
816362, "decodeImageData",
- "`decodeImageData has been deprecated`",
+ "`decodeImageData` has been deprecated.",
"decodeImageData has been deprecated. You should instead use "
"decodeImage, from the same interface. See {0} for more "
"information.".format(self.DECODE_LINK),
compat_type="warning", log_function=self.err.notice)
+ yield self.get_test_bug(
+ 827546, "nsIDOMNSEditableElement",
+ "In Firefox 20, using `QueryInterface` of a non-editable element "
+ "to `nsIDOMNSEditableElement` doesn't throw an exception as "
+ "expected.",
+ "In Firefox 20, using `QueryInterface` of a non-editable element "
+ "to `nsIDOMNSEditableElement` doesn't throw an exception as "
+ "expected. This has been fixed in Firefox 21. Using `instanceof` "
+ "is the recommended way of doing this, which avoids this error. "
+ "See {0} for more information.'".format(self.EDITABLE_LINK),

Orphan single quote?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
+ compat_type="warning", log_function=self.err.notice)
+
+
@register_generator
class Thunderbird7RegexTests(CompatRegexTestHelper):
"""Regex tests for the Thunderbird 7 update."""
@mattbasta

Orphan single quote?

Please sign in to comment.
Something went wrong with that request. Please try again.