From d59b6c924f5a723d4a88fb0babf680e79b7fc4e2 Mon Sep 17 00:00:00 2001 From: Matt Basta Date: Tue, 2 Oct 2012 17:56:12 -0700 Subject: [PATCH] Java entity flags for FX16 (bug 795428) --- tests/compat/test_gecko16.py | 12 ++++++++++++ validator/testcases/javascript/entity_values.py | 10 ++++++++-- validator/testcases/javascript/predefinedentities.py | 3 +++ 3 files changed, 23 insertions(+), 2 deletions(-) diff --git a/tests/compat/test_gecko16.py b/tests/compat/test_gecko16.py index 66faab713..67bb7c114 100644 --- a/tests/compat/test_gecko16.py +++ b/tests/compat/test_gecko16.py @@ -30,3 +30,15 @@ def test_mozIndexedDB(self): self.run_script_for_compat("mozIndexedDB.foo.bar;") self.assert_silent() self.assert_compat_error() + + def test_java(self): + """Test that `java` is flagged in Gecko 16.""" + self.run_script_for_compat("var x = java;") + self.assert_silent() + self.assert_compat_error() + + def test_Packages(self): + """Test that `Packages` is flagged in Gecko 16.""" + self.run_script_for_compat("var x = Packages;") + self.assert_silent() + self.assert_compat_error() diff --git a/validator/testcases/javascript/entity_values.py b/validator/testcases/javascript/entity_values.py index e18050f5d..6586d87d1 100644 --- a/validator/testcases/javascript/entity_values.py +++ b/validator/testcases/javascript/entity_values.py @@ -1,6 +1,6 @@ from call_definitions import open_in_chrome_context -from validator.compat import (FX10_DEFINITION, FX14_DEFINITION, TB14_DEFINITION, - TB15_DEFINITION) +from validator.compat import (FX10_DEFINITION, FX14_DEFINITION, FX16_DEFINITION, + TB14_DEFINITION, TB15_DEFINITION) from validator.constants import BUGZILLA_BUG @@ -53,6 +53,12 @@ def wrap(traverser): deprecated_entity(name="importHTMLFromURI", version=FX14_DEFINITION, message=DEP_IHF_MESSAGE, bug=482911) +JAVA_MESSAGE = "The global variables related to Java have been removed." +deprecated_entity(name="java", version=FX16_DEFINITION, + message=JAVA_MESSAGE, bug=748343) +deprecated_entity(name="Packages", version=FX16_DEFINITION, + message=JAVA_MESSAGE, bug=748343) + @register_entity("document.xmlEncoding") def xmlEncoding(traverser): diff --git a/validator/testcases/javascript/predefinedentities.py b/validator/testcases/javascript/predefinedentities.py index bb3b67782..f3216dcf1 100644 --- a/validator/testcases/javascript/predefinedentities.py +++ b/validator/testcases/javascript/predefinedentities.py @@ -573,6 +573,9 @@ def build_quick_xpcom(method, interface, traverser): "Consider using a different API if it is " "available in order to achieve similar " "functionality."}, + + u"java": entity("java"), + u"Packages": entity("Packages"), } CONTENT_DOCUMENT = GLOBAL_ENTITIES[u"content"]["value"][u"document"]