Implement AntennaAPI to manage resources #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this, falcon.API would register routes, but it was tricky to get a list of resources. In Antenna, resources are also components, so we want to have a list of the ones in the app so that we can more easily perform work across all the components in the app. For example, it's hard to do a health check if you can't access all the components in the app to ask them about their health. This fixes that.
|
Looks good. Merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this, falcon.API would register routes, but it was tricky to
get a list of resources. In Antenna, resources are also components, so
we want to have a list of the ones in the app so that we can more
easily perform work across all the components in the app.
For example, it's hard to do a health check if you can't access all
the components in the app to ask them about their health.
This fixes that.