From c2353d01421580292a52d7224fa8828bca258acb Mon Sep 17 00:00:00 2001 From: Elise Richards Date: Thu, 6 Jul 2023 18:04:04 -0500 Subject: [PATCH] For EXP-3625: Take getCoenrollingFeatureIds out of the interfaces --- .../experiments/nimbus/NimbusInterface.kt | 7 ------ .../mozilla/experiments/nimbus/NimbusTests.kt | 23 ------------------- components/nimbus/ios/Nimbus/NimbusApi.swift | 6 ----- 3 files changed, 36 deletions(-) diff --git a/components/nimbus/android/src/main/java/org/mozilla/experiments/nimbus/NimbusInterface.kt b/components/nimbus/android/src/main/java/org/mozilla/experiments/nimbus/NimbusInterface.kt index 93939e179e..696aa98eed 100644 --- a/components/nimbus/android/src/main/java/org/mozilla/experiments/nimbus/NimbusInterface.kt +++ b/components/nimbus/android/src/main/java/org/mozilla/experiments/nimbus/NimbusInterface.kt @@ -182,13 +182,6 @@ interface NimbusInterface : FeaturesInterface, GleanPlumbInterface, NimbusEventS */ fun resetTelemetryIdentifiers() = Unit - /** - * Get a list of feature ids where the feature allows co-enrollment. - * - * @return A list of experiment ids that allow co-enrollment. - */ - fun getCoenrollingFeatureIds(): List = listOf() - /** * Control the opt out for all experiments at once. This is likely a user action. */ diff --git a/components/nimbus/android/src/test/java/org/mozilla/experiments/nimbus/NimbusTests.kt b/components/nimbus/android/src/test/java/org/mozilla/experiments/nimbus/NimbusTests.kt index 7614d253eb..96902147a5 100644 --- a/components/nimbus/android/src/test/java/org/mozilla/experiments/nimbus/NimbusTests.kt +++ b/components/nimbus/android/src/test/java/org/mozilla/experiments/nimbus/NimbusTests.kt @@ -644,29 +644,6 @@ class NimbusTests { assertTrue(observed) } - - @Test - fun `test coenrolling features list is returned`() { - val expected = listOf("abc", "def", "ghi") - val observer = object : NimbusInterface.Observer { - override fun onUpdatesApplied(updated: List) { - runBlocking { - delay(250) - } - } - } - val nimbus = Nimbus( - context = context, - appInfo = appInfo, - coenrollingFeatureIds = expected, - server = null, - deviceInfo = deviceInfo, - observer = observer, - delegate = nimbusDelegate, - ) - - assertEquals(expected, nimbus.getCoenrollingFeatureIds()) - } } // Mocking utilities, from mozilla.components.support.test diff --git a/components/nimbus/ios/Nimbus/NimbusApi.swift b/components/nimbus/ios/Nimbus/NimbusApi.swift index 7815fe204b..5a6d50d97b 100644 --- a/components/nimbus/ios/Nimbus/NimbusApi.swift +++ b/components/nimbus/ios/Nimbus/NimbusApi.swift @@ -167,12 +167,6 @@ public protocol NimbusUserConfiguration { /// - Returns A list of `AvailableExperiment`s /// func getAvailableExperiments() -> [AvailableExperiment] - - /// Get a list of feature ids where the feature allows co-enrollment. - /// - /// - Returns A list of experiment ids that allow co-enrollment. - /// - func getCoenrollingFeatureIds() -> [String] } public protocol NimbusEventStore {