Skip to content

Commit

Permalink
Add Nimbus to swiftlint.yml and fix lints
Browse files Browse the repository at this point in the history
  • Loading branch information
travis79 committed Apr 16, 2021
1 parent 974806e commit c27ea96
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 6 deletions.
1 change: 1 addition & 0 deletions .swiftlint.yml
Expand Up @@ -4,6 +4,7 @@ included: # paths to include during linting. `--path` is ignored if present.
- components/support/ios
- components/logins/ios
- components/fxa-client/ios
- components/nimbus/ios
excluded:
- Carthage
- "**/*/ios/Generated"
Expand Down
10 changes: 6 additions & 4 deletions components/nimbus/ios/Nimbus/NimbusApi.swift
Expand Up @@ -9,9 +9,10 @@ import Foundation
/// Application developers are encouraged to build against this API protocol, and use the `Nimbus.create` method
/// to create the correct implementation for them.
///
/// Feature developers configuring their features shoiuld use the methods in `NimbusFeatureConfiguration`. These are safe to call from any thread.
/// Developers building UI tools for the user or QA to modify experiment enrollment will mostly use `NimbusUserConfiguration` methods.
/// Application developers integrating `Nimbus` into their app should use the methods in `NimbusStartup`.
/// Feature developers configuring their features shoiuld use the methods in `NimbusFeatureConfiguration`.
/// These are safe to call from any thread. Developers building UI tools for the user or QA to modify experiment
/// enrollment will mostly use `NimbusUserConfiguration` methods. Application developers integrating
/// `Nimbus` into their app should use the methods in `NimbusStartup`.
///
public protocol NimbusApi: class, NimbusStartup, NimbusFeatureConfiguration, NimbusUserConfiguration {}

Expand Down Expand Up @@ -66,7 +67,8 @@ public protocol NimbusStartup {
///
/// This is performed on a background thread.
///
/// - Parameter experimentsJson string representation of the JSON document in the same format delivered by RemoteSettings.
/// - Parameter experimentsJson string representation of the JSON document in the same format
/// delivered by RemoteSettings.
///
func setExperimentsLocally(_ experimentsJson: String)

Expand Down
4 changes: 2 additions & 2 deletions components/nimbus/ios/Nimbus/NimbusCreate.swift
Expand Up @@ -7,8 +7,8 @@ import Foundation
private let remoteSettingsBucket = "main"
private let remoteSettingsCollection = "nimbus-mobile-experiments"

private let LOG_TAG = "Nimbus.swift"
private let logger = Logger(tag: LOG_TAG)
private let logTag = "Nimbus.swift"
private let logger = Logger(tag: logTag)

public let defaultErrorReporter: NimbusErrorReporter = { err in
switch err {
Expand Down

0 comments on commit c27ea96

Please sign in to comment.