Add iOS import functionality #1078
Merged
Conversation
eaf2f12
to
7d7c95f
|
Great! Thanks for taking this, @thomcc! |
added 9 commits
Apr 24, 2019
…everybody thought they worked
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Fixes #1017
I've tested this locally on my bookmarks, and it works, but it needs real tests. It's also hard to test, since it's basically a big ol' mountain of SQL.
I also need to expose it over the FFI to iOS.Done.Pull Request checklist
cargo test --allproduces no test failurescargo clippy --all --all-targets --all-featuresruns without emitting any warningscargo fmtdoes not produce any changes to the code./gradlew ktlint detektruns without emitting any warnings[ci full]to the PR title.