Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add iOS import functionality #1078

Merged
merged 10 commits into from May 1, 2019

Conversation

Projects
None yet
3 participants
@thomcc
Copy link
Contributor

commented Apr 24, 2019

Fixes #1017

I've tested this locally on my bookmarks, and it works, but it needs real tests. It's also hard to test, since it's basically a big ol' mountain of SQL.

I also need to expose it over the FFI to iOS. Done.

Pull Request checklist

  • Quality: This PR builds and tests run cleanly
    • cargo test --all produces no test failures
    • cargo clippy --all --all-targets --all-features runs without emitting any warnings
    • cargo fmt does not produce any changes to the code
    • ./gradlew ktlint detekt runs without emitting any warnings
    • Note: For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due dilligence applied in selecting them.

@thomcc thomcc requested a review from linacambridge Apr 24, 2019

@thomcc thomcc force-pushed the import-ios branch 2 times, most recently from eaf2f12 to 7d7c95f Apr 24, 2019

@thomcc thomcc force-pushed the import-ios branch from f4df02c to 9ea0a8d Apr 29, 2019

@bug-mirror

This comment has been minimized.

Copy link
Collaborator

commented Apr 29, 2019

@linacambridge
Copy link
Member

left a comment

Great! Thanks for taking this, @thomcc! 💯

Show resolved Hide resolved components/places/src/import/ios_bookmarks.rs Outdated
Show resolved Hide resolved components/places/src/import/ios_bookmarks.rs
Show resolved Hide resolved components/places/src/import/ios_bookmarks.rs
Show resolved Hide resolved components/places/src/import/ios_bookmarks.rs Outdated
Show resolved Hide resolved components/places/src/import/ios_bookmarks.rs
Show resolved Hide resolved components/places/src/import/ios_bookmarks.rs
Show resolved Hide resolved components/places/src/bookmark_sync/store.rs
Show resolved Hide resolved components/places/src/import/ios_bookmarks.rs Outdated
Show resolved Hide resolved components/places/src/import/ios_bookmarks.rs Outdated
Show resolved Hide resolved components/places/src/import/ios_bookmarks.rs Outdated

thomcc added some commits Apr 24, 2019

@thomcc thomcc force-pushed the import-ios branch from 0d8ac88 to b196bc6 May 1, 2019

@thomcc thomcc force-pushed the import-ios branch from b196bc6 to bc8e07c May 1, 2019

@thomcc thomcc merged commit cc3217f into master May 1, 2019

10 of 11 checks passed

Taskcluster (pull_request) TaskGroup: Pending (for pull_request.edited)
Details
ci/circleci: Check Rust dependencies Your tests passed on CircleCI!
Details
ci/circleci: Check Rust formatting Your tests passed on CircleCI!
Details
ci/circleci: Check Swift formatting Your tests passed on CircleCI!
Details
ci/circleci: Deploy website Your tests passed on CircleCI!
Details
ci/circleci: Lint Rust with clippy Your tests passed on CircleCI!
Details
ci/circleci: Rust benchmarks Your tests passed on CircleCI!
Details
ci/circleci: Rust tests - beta Your tests passed on CircleCI!
Details
ci/circleci: Rust tests - stable Your tests passed on CircleCI!
Details
ci/circleci: Sync integration tests Your tests passed on CircleCI!
Details
ci/circleci: iOS build and test Your tests passed on CircleCI!
Details

@thomcc thomcc deleted the import-ios branch May 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.