New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send Tab PoC #391

Closed
wants to merge 5 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@rfk
Member

rfk commented Nov 12, 2018

This is @eoger's WIP that connects to #125; taking the liberty of making it a PR for visibility.

Requires #408.

@rfk rfk added the WIP label Nov 12, 2018

@rfk

This comment has been minimized.

Member

rfk commented Nov 12, 2018

@ncalexan or @thomcc, is there some sort of thing I should be doing to PRs to prevent taskcluster from running while they're WIP?

@eoger eoger force-pushed the send-tab-poc branch from 42b3239 to 2df9f63 Nov 13, 2018

@ncalexan

This comment has been minimized.

Member

ncalexan commented Nov 13, 2018

@ncalexan or @thomcc, is there some sort of thing I should be doing to PRs to prevent taskcluster from running while they're WIP?

There isn't (yet), but if you would like, a-c set the pattern to [ci skip], which I gather comes from Travis. I think we can do this in .taskcluster.yml -- the equivalent of https://github.com/mozilla-mobile/android-components/blob/52b42850b2845abb7dbabd376e00e6d448cd6df3/automation/taskcluster/decision_task.py#L112-L115 around

- $if: 'tasks_for == "github-pull-request"'
should achieve it.

@eoger eoger changed the title from Add client instance metadata APIs to Send Tab PoC Nov 16, 2018

@eoger eoger referenced this pull request Nov 16, 2018

Open

Clients instances API #408

@eoger eoger force-pushed the send-tab-poc branch from 2df9f63 to eae2d63 Nov 17, 2018

@eoger

This comment has been minimized.

Collaborator

eoger commented Nov 28, 2018

Closing in favor of #433 which is the non-hacky implementation.

@eoger eoger closed this Nov 28, 2018

@eoger eoger deleted the send-tab-poc branch Nov 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment