Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer rusqlite::Row::get_checked() over rusqlite::Row::get(), fixes #462 #488

Merged
merged 2 commits into from Jan 3, 2019

Conversation

Projects
None yet
2 participants
@mhammond
Copy link
Member

commented Dec 19, 2018

I hope I got this right. There's only 1 left in components/logins/examples/sync_pass_sql.rs, which I didn't bother fixing.

@mhammond mhammond requested a review from thomcc Dec 19, 2018

@thomcc
Copy link
Contributor

left a comment

Can you check that line numbers are preserved on failures if you return from tests with ?. If they are then it's looks good.

Show resolved Hide resolved components/places/src/api/history.rs Outdated
@thomcc

thomcc approved these changes Jan 3, 2019

Copy link
Contributor

left a comment

Looks great!

@mhammond mhammond merged commit fdcd207 into mozilla:master Jan 3, 2019

1 check passed

Taskcluster (pull_request) TaskGroup: success
Details

@mhammond mhammond deleted the mhammond:prefer_row_get_checked branch Jan 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.