Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't accumulate extra autocomplete matches and fix the matchers to actually...match #489

Merged
merged 3 commits into from Dec 19, 2018

Conversation

Projects
None yet
2 participants
@linacambridge
Copy link
Member

commented Dec 19, 2018

The fix for #322 is fairly small, but I went to add tests (turns out I didn't add any in the initial port, oops! They were just println!s. 馃槺), and fixed a slew of other things in the process. 馃槣

Closes #322.

linacambridge added some commits Dec 19, 2018

Fix the URL and suggestions matcher to work correctly.
* `strip_prefix_and_userinfo` returns the host, not just the
  path. The previous behavior caused the query to return no
  results, and try to query for nonsense (prepending `www.`
  to the path).
* `from_url_row` returns results up to the next path
  segment, not the complete URL from Places.
* The default search behavior on Desktop doesn't search titles
  or URLs by default. Using `SearchBehavior::all` caused
  `autocomplete_match` to always require titles and URLs to
  match.
* The suggestions matcher passes the bookmarked status to
  `autocomplete_match`.

@linacambridge linacambridge requested a review from thomcc Dec 19, 2018

@thomcc

thomcc approved these changes Dec 19, 2018

Copy link
Contributor

left a comment

Looks good!

@linacambridge linacambridge merged commit f13d0a0 into master Dec 19, 2018

5 checks passed

Taskcluster (pull_request) TaskGroup: success
Details
ci/circleci: Check Rust formatting Your tests passed on CircleCI!
Details
ci/circleci: Rust tests - beta Your tests passed on CircleCI!
Details
ci/circleci: Rust tests - nightly Your tests passed on CircleCI!
Details
ci/circleci: Rust tests - stable Your tests passed on CircleCI!
Details

@linacambridge linacambridge deleted the dont-accumulate-extra-matches branch Dec 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.