Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @Throws and ensureLocked/ensureUnlocked to android logins library. #495

Merged
merged 1 commit into from Jan 3, 2019

Conversation

Projects
None yet
2 participants
@thomcc
Copy link
Contributor

commented Dec 20, 2018

The first was requested in the last lockbox meeting, and I think I filed an issue for it but cant find it now.

The 2nd is because both lockbox and the android components repo have workarounds for the lack of these functions.

I also fixed up the logins docs a little.

@thomcc thomcc requested a review from ncalexan Dec 20, 2018

@thomcc thomcc requested review from mozilla/a-s-review and removed request for ncalexan Jan 2, 2019

@vladikoff
Copy link
Member

left a comment

r+, please see comments in #497 (review)

@thomcc thomcc force-pushed the logins-add-throws branch from 14b625d to c6d09b0 Jan 3, 2019

@thomcc thomcc merged commit bb0e1f5 into master Jan 3, 2019

5 checks passed

Taskcluster (pull_request) TaskGroup: success
Details
ci/circleci: Check Rust formatting Your tests passed on CircleCI!
Details
ci/circleci: Rust tests - beta Your tests passed on CircleCI!
Details
ci/circleci: Rust tests - nightly Your tests passed on CircleCI!
Details
ci/circleci: Rust tests - stable Your tests passed on CircleCI!
Details

@thomcc thomcc deleted the logins-add-throws branch Jan 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.