Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
referenced this pull request
Jan 9, 2019
This is starting to look like it is in reasonable shape - the main thing missing is "update" and external APIs. I'm inclined to think that the changes are getting significant enough that it would be better for everyone if we review and land as things stand, and complete further work in followups.
linacambridge left a comment
This is excellent, @mhammond, thank you for taking this on!
I wouldn't mind seeing this PR again, but I agree that it makes sense to land next week, and save the follow-up work for later PRs. I'm sure we'll be making changes as we add merging and syncing, anyway, so it's not worth fretting too much about the details at this point.
Let's do this!
I'm dismissing lina's review so that I can re-request it. Hopefully this works.