Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin reqwest to 0.9.5 in fxa-client and sync15 and cut another release #530

Merged
merged 2 commits into from Jan 10, 2019

Conversation

Projects
None yet
3 participants
@thomcc
Copy link
Contributor

commented Jan 10, 2019

This works around seanmonstar/reqwest#427, which was the cause of the issues we saw in mozilla-mobile/android-components#1692 (comment) and other places.

I also will cut a release when it lands, so this PR includes a changelog (the changelog assumes the release will happen tomorrow).

@thomcc thomcc requested a review from eoger Jan 10, 2019

@grigoryk grigoryk self-requested a review Jan 10, 2019

@thomcc thomcc force-pushed the pin-reqwest branch from 54310c3 to 11412c1 Jan 10, 2019

@thomcc thomcc removed the request for review from eoger Jan 10, 2019

@grigoryk grigoryk changed the title Pin reqwest to 0.9.5 in fxa-client and sync15 Pin reqwest to 0.9.5 in fxa-client and sync15 Jan 10, 2019

@thomcc thomcc changed the title Pin reqwest to 0.9.5 in fxa-client and sync15 Pin reqwest to 0.9.5 in fxa-client and sync15 and cut another release Jan 10, 2019

@thomcc thomcc force-pushed the pin-reqwest branch from 11412c1 to e3ec5a2 Jan 10, 2019

@thomcc

This comment has been minimized.

Copy link
Contributor Author

commented Jan 10, 2019

After this lands I'll do #529.

@vladikoff
Copy link
Member

left a comment

👍

@thomcc thomcc merged commit f2a9d20 into master Jan 10, 2019

5 of 6 checks passed

ci/circleci: Rust tests - nightly Your tests failed on CircleCI
Details
Taskcluster (pull_request) TaskGroup: success
Details
ci/circleci: Check Rust formatting Your tests passed on CircleCI!
Details
ci/circleci: Rust tests - beta Your tests passed on CircleCI!
Details
ci/circleci: Rust tests - stable Your tests passed on CircleCI!
Details
ci/circleci: Sync integration tests Your tests passed on CircleCI!
Details

@thomcc thomcc deleted the pin-reqwest branch Jan 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.