Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve logging in fxa-client, and bump android_logger version #533

Merged
merged 1 commit into from Jan 10, 2019

Conversation

Projects
None yet
2 participants
@thomcc
Copy link
Contributor

commented Jan 10, 2019

It looks like #472 has a decent amount of additional work needed, and this would have made debugging #530 much easier (and brings it in line with what the other crates do), so it doesn't seem like something I should just let live in my git stash stack forever.

@thomcc thomcc requested a review from eoger Jan 10, 2019

@thomcc thomcc force-pushed the fxa-ffi-logging branch 2 times, most recently from 222e004 to d7fbaad Jan 10, 2019

@thomcc thomcc force-pushed the fxa-ffi-logging branch from d7fbaad to 4b02a47 Jan 10, 2019

@eoger

eoger approved these changes Jan 10, 2019

Copy link
Contributor

left a comment

LGTM, it's a bit weird to log the name of the functions everywhere but if it helps debugging then I'm all for it. Thanks!

@thomcc

This comment has been minimized.

Copy link
Contributor Author

commented Jan 10, 2019

Because we have no stack traces, It's really useful to know which function you're in when an error happens.

@thomcc thomcc closed this Jan 10, 2019

@thomcc thomcc reopened this Jan 10, 2019

@thomcc

This comment has been minimized.

Copy link
Contributor Author

commented Jan 10, 2019

Whoops, clicked the wrong button there...

@thomcc thomcc merged commit a6b33c2 into master Jan 10, 2019

4 of 5 checks passed

Taskcluster (pull_request) TaskGroup: Pending (for pull_request.reopened)
Details
ci/circleci: Check Rust formatting Your tests passed on CircleCI!
Details
ci/circleci: Rust tests - beta Your tests passed on CircleCI!
Details
ci/circleci: Rust tests - stable Your tests passed on CircleCI!
Details
ci/circleci: Sync integration tests Your tests passed on CircleCI!
Details

@thomcc thomcc deleted the fxa-ffi-logging branch Jan 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.