Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FxA Network exception #535

Merged
merged 2 commits into from Jan 11, 2019

Conversation

Projects
None yet
3 participants
@eoger
Copy link
Contributor

commented Jan 10, 2019

Pretty much does what we do on the sync adapter side.
I've tested it manually on android-components.
Fixes #479

@eoger eoger requested a review from thomcc Jan 10, 2019

eoger added a commit to eoger/android-components that referenced this pull request Jan 10, 2019

@thomcc

thomcc approved these changes Jan 11, 2019

Copy link
Contributor

left a comment

Looks great!

Actually, could you add an entry into the changelog?

@eoger eoger force-pushed the fxa-network-errors branch from 4ed0287 to 27fe56b Jan 11, 2019

@eoger eoger merged commit ab27bb1 into master Jan 11, 2019

1 of 5 checks passed

Taskcluster (pull_request) TaskGroup: Pending (for pull_request.synchronize)
Details
ci/circleci: Rust tests - beta CircleCI is running your tests
Details
ci/circleci: Rust tests - stable CircleCI is running your tests
Details
ci/circleci: Sync integration tests CircleCI is running your tests
Details
ci/circleci: Check Rust formatting Your tests passed on CircleCI!
Details

@eoger eoger deleted the fxa-network-errors branch Jan 11, 2019

jonalmeida added a commit to mozilla-mobile/android-components that referenced this pull request Jan 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.