Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dubious error handling in logins and bug in ffi_support #593

Merged
merged 1 commit into from Feb 1, 2019

Conversation

Projects
None yet
2 participants
@thomcc
Copy link
Contributor

commented Jan 31, 2019

Reported by @justindarc.

@thomcc thomcc requested a review from mozilla/a-s-review Jan 31, 2019

@thomcc thomcc force-pushed the logins-sync-errors branch from 2c8fc6c to 3699e2c Jan 31, 2019

@justindarc
Copy link
Collaborator

left a comment

LGTM 👍

@thomcc thomcc merged commit c6119d7 into master Feb 1, 2019

5 checks passed

Taskcluster (pull_request) TaskGroup: success
Details
ci/circleci: Check Rust formatting Your tests passed on CircleCI!
Details
ci/circleci: Rust tests - beta Your tests passed on CircleCI!
Details
ci/circleci: Rust tests - stable Your tests passed on CircleCI!
Details
ci/circleci: Sync integration tests Your tests passed on CircleCI!
Details

@thomcc thomcc deleted the logins-sync-errors branch Feb 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.