Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix case where we'd still try to run a unicode string through reverse_host #691

Merged
merged 2 commits into from Feb 20, 2019

Conversation

Projects
None yet
2 participants
@thomcc
Copy link
Contributor

commented Feb 19, 2019

thomcc added some commits Feb 19, 2019

@thomcc thomcc requested a review from linacambridge Feb 19, 2019

@linacambridge
Copy link
Member

left a comment

Nice!

@thomcc thomcc merged commit cef2399 into master Feb 20, 2019

7 checks passed

Taskcluster (pull_request) TaskGroup: success
Details
ci/circleci: Build Carthage archive Your tests passed on CircleCI!
Details
ci/circleci: Check Rust formatting Your tests passed on CircleCI!
Details
ci/circleci: Rust benchmarks Your tests passed on CircleCI!
Details
ci/circleci: Rust tests - beta Your tests passed on CircleCI!
Details
ci/circleci: Rust tests - stable Your tests passed on CircleCI!
Details
ci/circleci: Sync integration tests Your tests passed on CircleCI!
Details

@thomcc thomcc deleted the punycode-better branch Feb 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.