Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fxa Swift refactor #713

Merged
merged 6 commits into from Feb 25, 2019

Conversation

Projects
None yet
2 participants
@eoger
Copy link
Contributor

commented Feb 25, 2019

Fixes #706.

@eoger eoger force-pushed the fxa-swift-refactor branch 2 times, most recently from cef4bfa to a5989e2 Feb 25, 2019

@eoger eoger requested a review from mozilla/a-s-review Feb 25, 2019

@thomcc

thomcc approved these changes Feb 25, 2019

Copy link
Contributor

left a comment

Looks good, after nits are addressed.

Show resolved Hide resolved components/fxa-client/ios/FxAClient/FirefoxAccount.swift Outdated
Show resolved Hide resolved components/fxa-client/ios/FxAClient/RustFxAFFI.h Outdated

@eoger eoger force-pushed the fxa-swift-refactor branch from a5989e2 to 74b9c8e Feb 25, 2019

@eoger eoger merged commit 92a4d4d into master Feb 25, 2019

0 of 7 checks passed

Taskcluster (pull_request) TaskGroup: Pending (for pull_request.synchronize)
Details
ci/circleci: Carthage build CircleCI is running your tests
Details
ci/circleci: Check Rust formatting CircleCI is running your tests
Details
ci/circleci: Rust benchmarks CircleCI is running your tests
Details
ci/circleci: Rust tests - beta CircleCI is running your tests
Details
ci/circleci: Rust tests - stable CircleCI is running your tests
Details
ci/circleci: Sync integration tests CircleCI is running your tests
Details

@eoger eoger deleted the fxa-swift-refactor branch Feb 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.