Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
RFC: Sync manager #714
thomcc left a comment
First review pass. Looks like it's moving in the right direction but I have some concerns.
P.S. I edited your initial PR comment to include the link to the rendered markdown doc, hope you don't mind.
I've pushed a new revision which I hope addresses most of the comments above - see #5d6e33b for the diff, but the main changes are:
I'm going to resolve the conversations above which I hope I've suitably addressed - please open new conversations for what I've missed or made worse.
I left some inline comments.
Could you expand on how the proposed SyncManager will tie in with the individual storage layers? E.g. history has a "sync" method, and SyncManager has a sync(engines...) method. Will the rust syncmanager implementation invoke rust engines itself, passing in the state that it maintains?
I'm assuming that Rust SyncManager will persist the state itself, since its APIs do not expose it.