Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] sandvich-android #83

Closed
wants to merge 16 commits into from
Closed

[WIP] sandvich-android #83

wants to merge 16 commits into from

Conversation

@carolkng
Copy link
Contributor

@carolkng carolkng commented Jun 20, 2018

Sandvich-ios but on android

Currently uses Thom's RustObject + RustResult to avoid memory leaks
let's not do this now ^^ in the interest of time

@carolkng carolkng force-pushed the carolkng:sand branch from 7833501 to e6ca1d0 Jun 20, 2018
@thomcc
Copy link
Contributor

@thomcc thomcc commented Jun 21, 2018

Currently uses Thom's RustObject + RustResult to avoid memory leaks

Sadly, without the changes to the FFI I had made at the same time to return Results by value, this still leaks memory whenever results are returned.

(The approach I think we've settled on in the mentat pr gets rid of the ExternResult/RustResult type anyway since it's error prone, and instead FFI functions an out parameter. This gives you additional type safety in the Java code, at the cost of being a little more tedious to write. The swift code can be adapted to have more type safety (like the java) but there are a few drawbacks, but it's no worse off in this approach, and much less likely to leak memory.)

@carolkng carolkng force-pushed the carolkng:sand branch 2 times, most recently from f4c5507 to b0fe7e1 Jun 21, 2018
@thomcc thomcc mentioned this pull request Jun 21, 2018
@carolkng carolkng force-pushed the carolkng:sand branch from 1d7715c to a510370 Jun 25, 2018
Thom Chiovoloni and others added 2 commits Jun 23, 2018
@carolkng carolkng force-pushed the carolkng:sand branch from 6a552c3 to bc6432a Jun 26, 2018
@mhammond

This comment has been minimized.

Copy link

@mhammond mhammond commented on bc6432a Jun 27, 2018

I suspect we don't want this .so checked in - I know that mentat etc uses a git symlink which might make more sense. (Obviously this isn't important for the WIP, but probably makes sense to address before merging)

@carolkng
Copy link
Contributor Author

@carolkng carolkng commented Jul 3, 2018

Closing because most of the work has been ported over to the android-components repo (library, sample app) and I'm not sure it makes sense to maintain the sample app in both repos any more.

@carolkng carolkng closed this Jul 3, 2018
dmose pushed a commit to dmose/application-services that referenced this pull request Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants