Clean up dependencies #98
Merged
Conversation
|
I'm not really sure who to tag for review here, but feel free to drop in and have a look at the changes |
| @@ -8,20 +8,19 @@ base64 = "0.9.0" | |||
| byteorder = "1.2.3" | |||
| failure = "0.1.1" | |||
| failure_derive = "0.1.1" | |||
| hawk = { git = "https://github.com/eoger/rust-hawk", branch = "use-openssl" } | |||
| hawk = { version = "1.0.2", optional = true } | |||
vladikoff
Jul 11, 2018
Contributor
👍
| lazy_static = "1.0.0" | ||
| log = "0.4" | ||
| openssl = "0.10.7" | ||
| rand = "0.5.0-pre.1" | ||
| openssl = { version = "0.10.7", optional = true } |
vladikoff
Jul 11, 2018
Contributor
How does that work with Android?
How does that work with Android?
vladikoff
Jul 11, 2018
Contributor
Oh so it will load it when browserid is enabled
Oh so it will load it when browserid is enabled
dmose
added a commit
to dmose/application-services
that referenced
this pull request
Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This PR removes a bunch of useless cargo dependencies whose job could be done by
ring(openssl, hmac, hkdf, sha256 digest).Some openssl functions could not be replaced, but thankfully these are only used by the "browserid" code, which is now behind a
browseridfeature flag.All of this means that we can build fxa_client for iOS without
openssl, which makes our building process way easier and faster.It also drops the size of the iOS universal lib from 40.5mb to 32.4mb, a 20% improvement.