Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
NSS rc_crypto replacement part 1 #998
rfk left a comment
It wasn't clear whether this was ready for review but I wanted to leave some preliminary comments.
Sticking with the
3 times, most recently
Apr 17, 2019
thomcc left a comment
Well, hopefully this is all fine. I feel like there's a lot of potential cleanup we could do around SECItem in particular, but for now... It's fine.
One last thing though, could you go through and make sure all our integer casts (e.g.