Fix COSEKeyTypeId serialization for non-EC keys#292
Merged
Conversation
jschanck
force-pushed
the
cose-key-type-id
branch
from
a68b40a to
03e8bac
Compare
mozkeeler
approved these changes
Aug 23, 2023
mozkeeler
left a comment
mozkeeler
left a comment
Collaborator
There was a problem hiding this comment.
Looks good - just a couple of questions.
mozkeeler
approved these changes
Aug 23, 2023
mozkeeler
left a comment
mozkeeler
left a comment
Collaborator
There was a problem hiding this comment.
Nice - I think I like this a lot better.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was previously serializing the enum label, e.g. "RSA", instead of the value from https://www.iana.org/assignments/cose/cose.xhtml#key-type.