Skip to content
This repository

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse code

bug 838571 - autophone - use shutil.move instead of os.rename, r=mcote

  • Loading branch information...
commit 771dcca73c053fe3007288c1ffd1ee32e19e4c89 1 parent cebc24d
Bob Clary authored February 05, 2013

Showing 1 changed file with 3 additions and 3 deletions. Show diff stats Hide diff stats

  1. 6  builds.py
6  builds.py
@@ -237,7 +237,7 @@ def get(self, buildurl, enable_unittests, force=False):
237 237
                 logging.error('IO Error retrieving build: %s.' % buildurl)
238 238
                 logging.error(traceback.format_exc())
239 239
                 return None
240  
-            os.rename(tmpf.name, build_path)
  240
+            shutil.move(tmpf.name, build_path)
241 241
         file(os.path.join(cache_build_dir, 'lastused'), 'w')
242 242
         symbols_path = os.path.join(cache_build_dir, 'symbols')
243 243
         if force or not os.path.exists(symbols_path):
@@ -295,7 +295,7 @@ def get(self, buildurl, enable_unittests, force=False):
295 295
                                   robocop_url)
296 296
                     logging.error(traceback.format_exc())
297 297
                     return None
298  
-                os.rename(tmpf.name, robocop_path)
  298
+                shutil.move(tmpf.name, robocop_path)
299 299
                 # XXX: assumes fixed buildurl-> fennec_ids.txt mapping
300 300
                 fennec_ids_url = urlparse.urljoin(buildurl, 'fennec_ids.txt')
301 301
                 fennec_ids_path = os.path.join(cache_build_dir, 'fennec_ids.txt')
@@ -309,7 +309,7 @@ def get(self, buildurl, enable_unittests, force=False):
309 309
                                   fennec_ids_url)
310 310
                     logging.error(traceback.format_exc())
311 311
                     return None
312  
-                os.rename(tmpf.name, fennec_ids_path)
  312
+                shutil.move(tmpf.name, fennec_ids_path)
313 313
         return cache_build_dir
314 314
 
315 315
     def clean_cache(self, preserve=[]):

0 notes on commit 771dcca

Please sign in to comment.
Something went wrong with that request. Please try again.