This repository was archived by the owner on Aug 14, 2020. It is now read-only.
Bug 1277653 - Add support for filtering whether tests should be run #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
autophone.py
Outdated
| tests = PhoneTest.match(build_url=build_url) | ||
| tests = PhoneTest.match(build_url=build_url, | ||
| branch=msg['branch'], | ||
| revision=msg['revision']) |
There was a problem hiding this comment.
build_url is going away since it no longer contains meta data in taskcluster build urls.
should have been repo=msg['branch'] ?
not sure about passing the revision and looking up the changeset inside of PhoneTest.match. More comments later.
…ased upon which directories were changed in a build; r?bc This adds a "run_if_changed" item to runtests section of a test configuration file. If present, the test will only run if files under those paths were modified in the revision being tested. This requires getting the pushlog and the diffs from the mercurial server in order to construct a list of files that were changed by that revision (and any other revision pushed at the same time.) If we are unable to retrieve the pushlog or the list of files, the test will run anyway, under the assumption that is both safer and a more likely to be noticed error condition than skipping the tests.
utils.py
Outdated
|
|
||
| if not pushlog: | ||
| logger.debug('Could not find pushlog for revision %s at %s' % | ||
| (revision, url)) |
There was a problem hiding this comment.
undefined revision. Maybe just use the url in the debug message?
| if cd.startswith(td): | ||
| logger.debug('PhoneTest.match: test %s dir %s matched changeset_dirs %s' % (test, td, cd)) | ||
| matched = True | ||
| break |
There was a problem hiding this comment.
I missed that this will still continue executing the for cd loop....
We need to check matched and break out of the for cd loop if it is true.
|
Squashed and pushed to: 46936d2 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a "run_if_changed" item to runtests section of a test configuration
file. If present, the test will only run if files under those paths were
modified in the revision being tested.
This requires getting the pushlog and the diffs from the mercurial server in
order to construct a list of files that were changed by that revision (and any
other revision pushed at the same time.)
If we are unable to retrieve the pushlog or the list of files, the test will
run anyway, under the assumption that is both safer and a more likely to be
noticed error condition than skipping the tests.