Support multi-level subdomains within a hosted zone. #119

Merged
merged 1 commit into from Mar 17, 2014

Projects

None yet

2 participants

@rfk
Member
rfk commented Feb 12, 2014

Fixes #118. @chilts IIRC you did most of the r53 work here, r?

@chilts
Contributor
chilts commented Feb 18, 2014

@rfk this looks good. Code fine. I just checked it out and did a test on fetching a domain from a sub-domain and a sub-sub-domain so yeah, cool. (I used a modified awsbox.js updaterecord.)

I'm not sure on the protocol on merging, tagging, releasing etc now with @lloyd no longer with us. Thoughts either of you?

@rfk
Member
rfk commented Feb 18, 2014

@lloyd is the only listed maintainer on npmjs.org so I guess we need his support to do a new release. Merge-policy wise, I nominate @chilts as a module peer for this thing :-)

@chilts chilts merged commit 8831969 into master Mar 17, 2014

1 check passed

default The Travis CI build passed
Details
@chilts chilts deleted the rfk/multi-level-subdomains branch Mar 17, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment