bug 1310220: Return empty list when user has no roles (#195). r=bhearsum

mozilla-releng · Dec 20, 2016 · 061f4bb · 061f4bb
1 parent 65b8d22
commit 061f4bb
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 6 deletions.
diff --git a/auslib/admin/views/permissions.py b/auslib/admin/views/permissions.py
@@ -102,10 +102,7 @@ class UserRolesView(AdminView):
 
     def get(self, username):
         roles = dbo.permissions.getUserRoles(username)
-        if roles:
-            return jsonify({"roles": roles})
-        else:
-            return Response(status=404, response="No roles found for user")
+        return jsonify({"roles": roles})
 
 
 class UserRoleView(AdminView):

diff --git a/auslib/test/admin/views/test_permissions.py b/auslib/test/admin/views/test_permissions.py
@@ -177,9 +177,9 @@ def testGetRoles(self):
         got = set(json.loads(ret.data)["roles"])
         self.assertEquals(got, set(["releng", "qa"]))
 
-    def testGetRolesMissingUser(self):
+    def testGetRolesMissingUserReturnsEmptyList(self):
         ret = self.client.get("/users/dean/roles")
-        self.assertStatusCode(ret, 404)
+        self.assertStatusCode(ret, 200)
 
     def testGrantRole(self):
         ret = self._put("/users/ashanti/roles/dev")