bug 739240 - permissions table UI #9

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
Contributor

peterbe commented Dec 19, 2012

@bhearsum r?

It looks like this now: http://cl.ly/LiTe

@@ -1,5 +1,5 @@
function getPermissionUrl(username, permission) {
- return SCRIPT_ROOT + '/users/' + username + '/permissions/' + permission;
+ return SCRIPT_ROOT + '/users/' + username + '/permissions/' + encodeURIComponent(permission);
@peterbe

peterbe Dec 19, 2012

Contributor

I'm surprised it worked before but I guess we were just lucky with how flask is working.
So instead of:

/users/balrogadmin/permissions//rules/:id

...it's now...

/users/balrogadmin/permissions/%2Frules%2F%3Aid

Which, although quite off-topic, just feels a lot safer.

data_version.val(data.new_data_version);
- postAJAXLoad(form);
+ postAJAXLoad();
@peterbe

peterbe Dec 19, 2012

Contributor

If you call postAJAXLoad() with a form (jquery) element, all inputs are reset.

That's only applicable for forms for adding stuff where you want the inputs to go back to being blank after the addition.

Member

mozbhearsum commented Dec 20, 2012

Looks good to me, feel free to merge anytime.

Contributor

peterbe commented Dec 20, 2012

@peterbe peterbe closed this Dec 20, 2012

JohanLorenzo pushed a commit to JohanLorenzo/balrog that referenced this pull request Sep 9, 2016

[balrog-ui] Merge pull request #9 from peterbe/bug-1179290-dont-depen…
…d-on-google-fonts-on-http

fixes bug 1179290 - Don't depend on Google Fonts on HTTP
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment