Skip to content

Commit 3b032f0

Browse files
committed
[fix bug 1121733] Tabs missing from /firefox/tips pages
1 parent 75eab2e commit 3b032f0

3 files changed

Lines changed: 6 additions & 6 deletions

File tree

bedrock/firefox/templates/firefox/desktop/tips.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ <h2>{{ _('5 top tips, tricks and time-saving tools') }}</h2>
4040
</div>
4141
</div>
4242

43-
<div id="share-nav-wrapper" class="share-wrapper">
43+
<div id="main-nav-wrapper" class="button-wrapper">
4444
{% include 'firefox/includes/social-share.html' %}
4545
<nav id="tips-nav-direct">
4646
<ol role="tablist">
@@ -249,7 +249,7 @@ <h3>{{ _('Congratulations') }}</h3>
249249
{{ _('You’re an expert!') }}
250250
{{ _('Now help your friends master Firefox.') }}
251251
</p>
252-
<div class="share-wrapper">
252+
<div class="button-wrapper">
253253
{% include 'firefox/includes/social-share.html' %}
254254
</div>
255255
</div>

media/css/firefox/desktop/tips.less

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,7 @@
138138
}
139139
}
140140

141-
#share-nav-wrapper {
141+
#main-nav-wrapper {
142142
.clearfix();
143143

144144
.socialshare {
@@ -413,7 +413,7 @@ html[dir='rtl'] {
413413
margin-left: @baseLine;
414414
}
415415

416-
#share-nav-wrapper .socialshare {
416+
#main-nav-wrapper .socialshare {
417417
float: right;
418418
}
419419

@@ -505,7 +505,7 @@ html[dir='rtl'] {
505505
.font-size(22px);
506506
}
507507

508-
#share-nav-wrapper {
508+
#main-nav-wrapper {
509509
margin: -20px 156px 0 0;
510510

511511
.socialshare {

media/js/firefox/desktop/tips.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -162,7 +162,7 @@
162162
// GA tracking
163163
$('.share-button').on('click', function() {
164164
// determine position
165-
var pos = ($(this).closest('.share-wrapper').prop('id') === 'share-nav-wrapper') ? 'top' : 'bottom';
165+
var pos = ($(this).closest('.button-wrapper').prop('id') === 'main-nav-wrapper') ? 'top' : 'bottom';
166166

167167
gaTrack(['_trackEvent','/desktop/tips/ Interactions','Social Share', 'share drop-down ' + pos]);
168168
});

0 commit comments

Comments
 (0)