Skip to content

Commit 9cd35b4

Browse files
committed
Fix Bug 1118339 - Update https://www.mozilla.org/en-US/firefox/channel/#aurora for Android ARM links to reflect new FTP directory changes
1 parent d8c8a0f commit 9cd35b4

File tree

4 files changed

+31
-13
lines changed

4 files changed

+31
-13
lines changed

bedrock/mozorg/helpers/download_buttons.py

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,10 @@
3131
'direct': 'https://download.mozilla.org/',
3232
'aurora': nightly_desktop,
3333
'aurora-l10n': nightly_desktop + '-l10n',
34-
'aurora-android-armv7': nightly_android + (
35-
'/en-US/fennec-%s.en-US.android-arm.apk'),
34+
'aurora-android-api-9': nightly_android + (
35+
'-api-9/fennec-%s.multi.android-arm.apk'),
36+
'aurora-android-api-11': nightly_android + (
37+
'-api-11/fennec-%s.multi.android-arm.apk'),
3638
'aurora-android-x86': nightly_android + (
3739
'-x86/fennec-%s.multi.android-i386.apk'),
3840
}
@@ -128,22 +130,26 @@ def make_download_link(product, build, version, platform, locale,
128130
def android_builds(build, builds=None):
129131
builds = builds or []
130132
android_link = settings.GOOGLE_PLAY_FIREFOX_LINK
133+
variations = {
134+
'api-9': 'Gingerbread',
135+
'api-11': 'Honeycomb+ ARMv7',
136+
'x86': 'x86',
137+
}
131138

132139
if build.lower() == 'beta':
133140

134141
android_link = android_link.replace('org.mozilla.firefox',
135142
'org.mozilla.firefox_beta')
136143

137144
if build == 'aurora':
138-
for arch_pretty in ['ARMv7', 'x86']:
139-
arch = arch_pretty.lower()
140-
link = (download_urls['aurora-android-%s' % arch] %
145+
for type, arch_pretty in variations.items():
146+
link = (download_urls['aurora-android-%s' % type] %
141147
mobile_details.latest_version('aurora'))
142148

143149
builds.append({'os': 'os_android',
144150
'os_pretty': 'Android',
145151
'os_arch_pretty': 'Android %s' % arch_pretty,
146-
'arch': arch,
152+
'arch': 'x86' if type == 'x86' else 'armv7 %s' % type,
147153
'arch_pretty': arch_pretty,
148154
'download_link': link})
149155

bedrock/mozorg/tests/test_helper_download_buttons.py

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -197,14 +197,16 @@ def test_aurora_mobile(self):
197197
{'request': get_request}))
198198

199199
list = doc('.download-list li')
200-
eq_(list.length, 2)
201-
eq_(pq(list[0]).attr('class'), 'os_android armv7')
202-
eq_(pq(list[1]).attr('class'), 'os_android x86')
200+
eq_(list.length, 3)
201+
eq_(pq(list[0]).attr('class'), 'os_android armv7 api-9')
202+
eq_(pq(list[1]).attr('class'), 'os_android armv7 api-11')
203+
eq_(pq(list[2]).attr('class'), 'os_android x86')
203204

204205
list = doc('.download-other .arch')
205-
eq_(list.length, 2)
206-
eq_(pq(list[0]).attr('class'), 'arch armv7')
207-
eq_(pq(list[1]).attr('class'), 'arch x86')
206+
eq_(list.length, 3)
207+
eq_(pq(list[0]).attr('class'), 'arch armv7 api-9')
208+
eq_(pq(list[1]).attr('class'), 'arch armv7 api-11')
209+
eq_(pq(list[2]).attr('class'), 'arch x86')
208210

209211
def test_beta_mobile(self):
210212
rf = RequestFactory()

media/css/sandstone/buttons.less

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -678,17 +678,22 @@
678678

679679
// Android architecture detection
680680

681+
.download-button .download-list .os_android.api-9,
681682
.download-button .download-list .os_android.x86,
682-
.download-button .download-other.os_android .armv7,
683+
.download-button .download-other.os_android .api-11,
684+
.android.gingerbread .download-button .download-list .os_android.api-11,
685+
.android.gingerbread .download-button .download-other.os_android .api-9,
683686
.android.x86 .download-button .download-list .os_android.armv7,
684687
.android.x86 .download-button .download-other.os_android .x86 {
685688
display: none !important;
686689
}
687690

691+
.android.gingerbread .download-button .download-list .os_android.api-9,
688692
.android.x86 .download-button .download-list .os_android.x86 {
689693
display: block !important;
690694
}
691695

696+
.android.gingerbread .download-button .download-other.os_android .api-11,
692697
.android.x86 .download-button .download-other.os_android .armv7 {
693698
display: inline !important;
694699
}

media/js/base/site.js

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -133,6 +133,11 @@
133133
var platform = window.site.platform = window.site.getPlatform();
134134
if (platform !== 'windows') {
135135
h.className = h.className.replace('windows', platform);
136+
137+
// Add class to support downloading Firefox Aurora for Android Gingerbread
138+
if (platform === 'android' && navigator.userAgent.match(/Android\ 2\.3/)) {
139+
h.className += ' gingerbread';
140+
}
136141
}
137142

138143
// Add class to reflect the microprocessor architecture info

0 commit comments

Comments
 (0)