Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create macros for Protocol components #6107

Closed
alexgibson opened this issue Aug 31, 2018 · 0 comments
Closed

Create macros for Protocol components #6107

alexgibson opened this issue Aug 31, 2018 · 0 comments
Assignees
Labels
Moz.org Self-initiated projects, such as site-wide improvements, navigation/IA, code cleanup, etc. Papercuts 💸 Tech debt payoff

Comments

@alexgibson
Copy link
Member

Now that we have numerous pages on mozorg built using Protocol, we should start to think about making components built using Jinja more reusable, so updating markup due to change upstream doesn't become difficult and time consuming. We should make a new set of Jinja macros for Protcol components, which can be imported as needed by individual page templates

Looking at these three pages:

https://www.mozilla.org/en-US/
https://www.mozilla.org/en-US/about/
https://www.mozilla.org/en-US/firefox/pocket/

I can see Cards, Billboards, Feature Cards, and Hero sections, but they all have separate implementations for the markup, so when making updates we'd need to address each page separately. It could be much easier and faster just to update the markup in a single macro, which each page then pulls from.

We should try and move these pages to use shared components sooner rather than later, else the job will get bigger as time goes on and more pages are built.

@alexgibson alexgibson added the Papercuts 💸 Tech debt payoff label Aug 31, 2018
@mozilla mozilla deleted a comment from cvidal2 Sep 4, 2018
@alexgibson alexgibson self-assigned this Sep 5, 2018
@alexgibson alexgibson added this to In Progress in Moz.org Project Overview Sep 5, 2018
alexgibson added a commit to alexgibson/bedrock that referenced this issue Sep 10, 2018
alexgibson added a commit to alexgibson/bedrock that referenced this issue Sep 10, 2018
alexgibson added a commit to alexgibson/bedrock that referenced this issue Sep 10, 2018
@alexgibson alexgibson moved this from In Progress to In Review in Moz.org Project Overview Sep 10, 2018
@alexgibson alexgibson moved this from In Review to In Progress in Moz.org Project Overview Sep 14, 2018
alexgibson added a commit to alexgibson/bedrock that referenced this issue Sep 17, 2018
alexgibson added a commit to alexgibson/bedrock that referenced this issue Sep 25, 2018
alexgibson added a commit to alexgibson/bedrock that referenced this issue Oct 1, 2018
@alexgibson alexgibson added Needs Review Awaiting code review and removed Needs Review Awaiting code review labels Oct 1, 2018
alexgibson added a commit to alexgibson/bedrock that referenced this issue Oct 7, 2018
alexgibson added a commit to alexgibson/bedrock that referenced this issue Oct 7, 2018
alexgibson added a commit to alexgibson/bedrock that referenced this issue Oct 7, 2018
alexgibson added a commit to alexgibson/bedrock that referenced this issue Oct 17, 2018
alexgibson added a commit to alexgibson/bedrock that referenced this issue Oct 17, 2018
alexgibson added a commit to alexgibson/bedrock that referenced this issue Oct 22, 2018
@djst djst added the Moz.org Self-initiated projects, such as site-wide improvements, navigation/IA, code cleanup, etc. label Oct 23, 2018
alexgibson added a commit to alexgibson/bedrock that referenced this issue Oct 23, 2018
@alexgibson alexgibson added the Needs Review Awaiting code review label Oct 24, 2018
alexgibson added a commit to alexgibson/bedrock that referenced this issue Oct 24, 2018
alexgibson added a commit to alexgibson/bedrock that referenced this issue Oct 24, 2018
alexgibson added a commit to alexgibson/bedrock that referenced this issue Oct 25, 2018
Moz.org Project Overview automation moved this from In Progress to Done Oct 26, 2018
@stephaniehobson stephaniehobson removed the Needs Review Awaiting code review label Nov 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Moz.org Self-initiated projects, such as site-wide improvements, navigation/IA, code cleanup, etc. Papercuts 💸 Tech debt payoff
Projects
No open projects
Development

No branches or pull requests

3 participants