Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update eslint to use @mozilla-protocol/eslint-config #6868

Closed
3 of 6 tasks
alexgibson opened this issue Feb 28, 2019 · 0 comments
Closed
3 of 6 tasks

Update eslint to use @mozilla-protocol/eslint-config #6868

alexgibson opened this issue Feb 28, 2019 · 0 comments
Assignees
@amychurchwell
Labels
Papercuts 💸 Tech debt payoff
Projects
Websites Durable Team Backlog
Milestone
Sprint - 2019-05-...

Comments

@alexgibson
Copy link
Member

alexgibson commented Feb 28, 2019 •
edited

Description

Now that bedrock has updated to Gulp 4, we should also update the version of ESLint that bedrock uses. This would also be a good time to switch to using the new Protocol shared config.

Estimates

Estimates
TL
PM
ENG 1 day
SEO
ANA
DES
COPY

💛 Success Criteria 💛

  • Bedrock is using the latest version of ESLint.
  • Bedrock config inerits from Protocol config.
  • JS is free of linting errors.

Tasks

  • Update gulp-eslint dependency to the laterst NPM version.
  • Import new Protocol shared config.
  • Update any existing linting rules where necessary.
@alexgibson alexgibson added the Papercuts 💸 Tech debt payoff label Feb 28, 2019
@alexgibson alexgibson changed the title Update eslint to use use @mozilla-protocol/eslint-config Update eslint to use @mozilla-protocol/eslint-config Feb 28, 2019
@alexgibson alexgibson added this to Lights on - Maintenance, Technical Debt in Websites Durable Team Backlog Feb 28, 2019
@suriyaa suriyaa mentioned this issue Mar 18, 2019
Closed
alexgibson added a commit to alexgibson/bedrock that referenced this issue Apr 1, 2019
@alexgibson
Update ESLint to consume @mozilla-protocol/eslint-config (Fixes mozil…
0891417 
…la#6868)
@alexgibson alexgibson mentioned this issue Apr 1, 2019
Merged
alexgibson added a commit to alexgibson/bedrock that referenced this issue Apr 1, 2019
@alexgibson
Update ESLint to consume @mozilla-protocol/eslint-config (Fixes mozil…
9345560 
…la#6868)
alexgibson added a commit to alexgibson/bedrock that referenced this issue Apr 1, 2019
@alexgibson
Update ESLint to consume @mozilla-protocol/eslint-config (Fixes mozil…
ba21e8d 
…la#6868)
alexgibson added a commit to alexgibson/bedrock that referenced this issue Apr 1, 2019
@alexgibson
Update ESLint to consume @mozilla-protocol/eslint-config (Fixes mozil…
89c639d 
…la#6868)
alexgibson added a commit to alexgibson/bedrock that referenced this issue Apr 1, 2019
@alexgibson
Update ESLint to consume @mozilla-protocol/eslint-config (Fixes mozil…
707acbd 
…la#6868)
alexgibson added a commit to alexgibson/bedrock that referenced this issue Apr 1, 2019
@alexgibson
Update ESLint to consume @mozilla-protocol/eslint-config (Fixes mozil…
4a6ac15 
…la#6868)
alexgibson added a commit to alexgibson/bedrock that referenced this issue Apr 1, 2019
@alexgibson
Update ESLint to consume @mozilla-protocol/eslint-config (Fixes mozil…
c55d8af 
…la#6868)
alexgibson added a commit to alexgibson/bedrock that referenced this issue Apr 1, 2019
@alexgibson
Update ESLint to consume @mozilla-protocol/eslint-config (Fixes mozil…
2616984 
…la#6868)
alexgibson added a commit to alexgibson/bedrock that referenced this issue Apr 1, 2019
@alexgibson
Update ESLint to consume @mozilla-protocol/eslint-config (Fixes mozil…
5340a91 
…la#6868)
alexgibson added a commit to alexgibson/bedrock that referenced this issue Apr 1, 2019
@alexgibson
Update ESLint to consume @mozilla-protocol/eslint-config (Fixes mozil…
183d4bb 
…la#6868)
alexgibson added a commit to alexgibson/bedrock that referenced this issue Apr 2, 2019
@alexgibson
Update ESLint to consume @mozilla-protocol/eslint-config (Fixes mozil…
f858c18 
…la#6868)
alexgibson added a commit to alexgibson/bedrock that referenced this issue Apr 2, 2019
@alexgibson
Update ESLint to consume @mozilla-protocol/eslint-config (Fixes mozil…
1b0e0b4 
…la#6868)
alexgibson added a commit to alexgibson/bedrock that referenced this issue Apr 5, 2019
@alexgibson
Update ESLint to consume @mozilla-protocol/eslint-config (Fixes mozil…
fd2b4fc 
…la#6868)
alexgibson added a commit to alexgibson/bedrock that referenced this issue Apr 9, 2019
@alexgibson
Update ESLint to consume @mozilla-protocol/eslint-config (Fixes mozil…
19616ff 
…la#6868)
@alexgibson alexgibson self-assigned this Apr 9, 2019
@alexgibson alexgibson added the Needs Review Awaiting code review label Apr 9, 2019
alexgibson added a commit to alexgibson/bedrock that referenced this issue Apr 9, 2019
@alexgibson
Update ESLint to consume @mozilla-protocol/eslint-config (Fixes mozil…
e40ee1c 
…la#6868)
alexgibson added a commit to alexgibson/bedrock that referenced this issue Apr 11, 2019
@alexgibson
Update ESLint to consume @mozilla-protocol/eslint-config (Fixes mozil…
64d1085 
…la#6868)
alexgibson added a commit to alexgibson/bedrock that referenced this issue Apr 15, 2019
@alexgibson
Update ESLint to consume @mozilla-protocol/eslint-config (Fixes mozil…
eaa6dda 
…la#6868)
alexgibson added a commit to alexgibson/bedrock that referenced this issue Apr 17, 2019
@alexgibson
Update ESLint to consume @mozilla-protocol/eslint-config (Fixes mozil…
9377364 
…la#6868)
alexgibson added a commit to alexgibson/bedrock that referenced this issue Apr 23, 2019
@alexgibson
Update ESLint to consume @mozilla-protocol/eslint-config (Fixes mozil…
b2d0d7c 
…la#6868)
alexgibson added a commit to alexgibson/bedrock that referenced this issue Apr 23, 2019
@alexgibson
Update ESLint to consume @mozilla-protocol/eslint-config (Fixes mozil…
ffbee8e 
…la#6868)
alexgibson added a commit to alexgibson/bedrock that referenced this issue Apr 24, 2019
@alexgibson
Update ESLint to consume @mozilla-protocol/eslint-config (Fixes mozil…
3937ab9 
…la#6868)
alexgibson added a commit to alexgibson/bedrock that referenced this issue Apr 24, 2019
@alexgibson
Update ESLint to consume @mozilla-protocol/eslint-config (Fixes mozil…
f898d2e 
…la#6868)
alexgibson added a commit to alexgibson/bedrock that referenced this issue Apr 26, 2019
@alexgibson
Update ESLint to consume @mozilla-protocol/eslint-config (Fixes mozil…
f04da90 
…la#6868)
alexgibson added a commit to alexgibson/bedrock that referenced this issue Apr 29, 2019
@alexgibson
Update ESLint to consume @mozilla-protocol/eslint-config (Fixes mozil…
88d2791 
…la#6868)
alexgibson added a commit to alexgibson/bedrock that referenced this issue Apr 29, 2019
@alexgibson
Update ESLint to consume @mozilla-protocol/eslint-config (Fixes mozil…
9390441 
…la#6868)
alexgibson added a commit to alexgibson/bedrock that referenced this issue Apr 30, 2019
@alexgibson
Update ESLint to consume @mozilla-protocol/eslint-config (Fixes mozil…
67a7dd2 
…la#6868)
alexgibson added a commit to alexgibson/bedrock that referenced this issue May 1, 2019
@alexgibson
Update ESLint to consume @mozilla-protocol/eslint-config (Fixes mozil…
d35405a 
…la#6868)
alexgibson added a commit to alexgibson/bedrock that referenced this issue May 2, 2019
@alexgibson
Update ESLint to consume @mozilla-protocol/eslint-config (Fixes mozil…
cd9f32a 
…la#6868)
alexgibson added a commit to alexgibson/bedrock that referenced this issue May 2, 2019
@alexgibson
Update ESLint to consume @mozilla-protocol/eslint-config (Fixes mozil…
6ff77e8 
…la#6868)
alexgibson added a commit to alexgibson/bedrock that referenced this issue May 2, 2019
@alexgibson
Update ESLint to consume @mozilla-protocol/eslint-config (Fixes mozil…
0031048 
…la#6868)
alexgibson added a commit to alexgibson/bedrock that referenced this issue May 7, 2019
@alexgibson
Update ESLint to consume @mozilla-protocol/eslint-config (Fixes mozil…
f734453 
…la#6868)
@stephaniehobson stephaniehobson removed the Needs Review Awaiting code review label Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amychurchwell amychurchwell

Labels
Papercuts 💸 Tech debt payoff
Projects
No open projects
Websites Durable Team Backlog
Lights on - Maintenance, Technical Debt
Milestone
Sprint - 2019-05-06 to 2019-05-24
Development

No branches or pull requests
4 participants
@alexgibson @stephaniehobson @ejregithub @amychurchwell