Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Bug 974005 - Add back Gigabit Blog link #1716

Merged
merged 1 commit into from

2 participants

bedrock/gigabit/templates/gigabit/apply.html
@@ -23,6 +23,7 @@
<ul id="nav-main-menu">
<li>{{_('<a href="%s">Home</a>')|format(url('gigabit.gigabit')) }}</li>
<li><b>{{_('Apply')}}</b></li>
+ <li><a href="http://blog.mozilla.org/gigabit/">{{_('Blog')}}</a>
@alexgibson Collaborator

Looks like you're missing the closing </li> here?

Also the link can use https:// instead of http://

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
bedrock/gigabit/templates/gigabit/gigabit.html
@@ -23,6 +23,7 @@
<ul id="nav-main-menu">
<li><b>{{_('Home')}}</b></li>
<li>{{_('<a href="%s">Apply</a>')|format(url('gigabit.apply')) }}</li>
+ <li><a href="http://blog.mozilla.org/gigabit/">{{_('Blog')}}</a>
@alexgibson Collaborator

Same as above

@mmmavis
mmmavis added a note

ah, I'll fix it =)

Is there a general guideline about when to use protocol relative urls and when to specify them?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@alexgibson
Collaborator

I didn't mean use a protocol relative URL, just change it to https. If you click the link you will see it redirects to https anyway, so you might as well just set it directly.

You generally don't need to use protocol relative URL's on page links, only for loading resources (e.g. embedding a video or loading a remote JS). There's a good article on protocol relative URL's here: http://www.paulirish.com/2010/the-protocol-relative-url/

@mmmavis

thanks Alex!

Now let me practice with rebasing & squashing =)

@mmmavis

ummm looks like I did something wrong again?

@alexgibson
Collaborator

You may just need to try rebasing again.

There are some steps to follow in the Git workflow section in our docs: http://bedrock.readthedocs.org/en/latest/contribute.html#git-workflow

Once rebased you can squash your commits: http://bedrock.readthedocs.org/en/latest/contribute.html#squashing-your-commits

@alexgibson
Collaborator

r+

@alexgibson alexgibson merged commit d74bee6 into from
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Feb 21, 2014
  1. @mmmavis
This page is out of date. Refresh to see the latest.
View
1  bedrock/gigabit/templates/gigabit/apply.html
@@ -23,6 +23,7 @@
<ul id="nav-main-menu">
<li>{{_('<a href="%s">Home</a>')|format(url('gigabit.gigabit')) }}</li>
<li><b>{{_('Apply')}}</b></li>
+ <li><a href="https://blog.mozilla.org/gigabit/">{{_('Blog')}}</a></li>
</ul>
</nav>
{% endblock %}
View
1  bedrock/gigabit/templates/gigabit/gigabit.html
@@ -23,6 +23,7 @@
<ul id="nav-main-menu">
<li><b>{{_('Home')}}</b></li>
<li>{{_('<a href="%s">Apply</a>')|format(url('gigabit.apply')) }}</li>
+ <li><a href="https://blog.mozilla.org/gigabit/">{{_('Blog')}}</a></li>
</ul>
</nav>
{% endblock %}
Something went wrong with that request. Please try again.