Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Bug 974803 - MWC Partners page: improve display for locales #1726

Merged
merged 1 commit into from

2 participants

@flodolo
Collaborator

el: title overlapping with Firefox logo
zh-TW: text covered by Firefox’s tail in Marketplace section
cs, el, pl, ro, sr: arrow above the menu on the left is cut for locales not using font Journal
ja: text slightly overlaps with the menu on the left

@flodolo
Collaborator

Some screenshots with this fix applied.

el
schermata 2014-02-24 alle 08 01 01

schermata 2014-02-24 alle 08 44 22

zh-TW
schermata 2014-02-24 alle 08 00 45

ja
schermata 2014-02-24 alle 08 44 33

@flodolo
Collaborator

Don't merge for now, noticed another problem for some locales.

@flodolo flodolo Bug 974803 - MWC Partners page: fix el, zh-TW
el: title overlapping with Firefox logo
zh-TW: text covered by Firefox’s tail in Marketplace section
cs, el, ja, pl, ro, sr: fix #explore arrow (cur or overlap)
02c61ad
@flodolo
Collaborator

PR updated and tested on OS X, Windows 8 and Linux.

@flodolo
Collaborator

We got the Hungarian slogan, I'll look into it in a few minutes and update the PR if necessary

@flodolo
Collaborator

Proposed slogan for hu fits with the standard font size (80px).

schermata 2014-02-24 alle 16 59 03

@jpetto r?

@jpetto
Collaborator

Looking good. r+!

@jpetto jpetto merged commit b15f552 into from
@flodolo flodolo deleted the branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Feb 24, 2014
  1. @flodolo

    Bug 974803 - MWC Partners page: fix el, zh-TW

    flodolo authored
    el: title overlapping with Firefox logo
    zh-TW: text covered by Firefox’s tail in Marketplace section
    cs, el, ja, pl, ro, sr: fix #explore arrow (cur or overlap)
This page is out of date. Refresh to see the latest.
Showing with 19 additions and 1 deletion.
  1. +19 −1 media/css/firefox/partners/desktop.less
View
20 media/css/firefox/partners/desktop.less
@@ -798,6 +798,10 @@ html[lang="el"] {
line-height: 1.2;
}
+ #overview h2 {
+ font-size: 66px;
+ }
+
.partner-article .article-header nav a {
font-size: 12px;
line-height: 1.2;
@@ -808,7 +812,6 @@ html[lang="el"] {
}
}
-html[lang="el"],
html[lang="fr"],
html[lang="pt-BR"] {
#overview h2 {
@@ -816,6 +819,11 @@ html[lang="pt-BR"] {
}
}
+html[lang="zh-TW"] {
+ #marketplace-overview h4 {
+ margin-top: 20px;
+ }
+}
// Cancel use of Journal font for these locales
html[lang="cs"],
@@ -829,6 +837,10 @@ html[lang="sr"] {
line-height: 1.2;
font-family: inherit;
}
+
+ #explore {
+ min-height: 42px;
+ }
}
html[lang|="es"],
@@ -845,6 +857,12 @@ html[lang="ca"] {
}
}
+html[lang="ja"] {
+ #explore {
+ padding-left: 65px;
+ }
+}
+
html[lang="zh-CN"] {
#overview .intro p {
padding: 0 10px;
Something went wrong with that request. Please try again.