Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Bug 974803 - MWC Partners page: improve display for locales #1726

Merged
merged 1 commit into from Feb 24, 2014

Conversation

Projects
None yet
2 participants
Contributor

flodolo commented Feb 24, 2014

el: title overlapping with Firefox logo
zh-TW: text covered by Firefox’s tail in Marketplace section
cs, el, pl, ro, sr: arrow above the menu on the left is cut for locales not using font Journal
ja: text slightly overlaps with the menu on the left

Contributor

flodolo commented Feb 24, 2014

Some screenshots with this fix applied.

el
schermata 2014-02-24 alle 08 01 01

schermata 2014-02-24 alle 08 44 22

zh-TW
schermata 2014-02-24 alle 08 00 45

ja
schermata 2014-02-24 alle 08 44 33

Contributor

flodolo commented Feb 24, 2014

Don't merge for now, noticed another problem for some locales.

Bug 974803 - MWC Partners page: fix el, zh-TW
el: title overlapping with Firefox logo
zh-TW: text covered by Firefox’s tail in Marketplace section
cs, el, ja, pl, ro, sr: fix #explore arrow (cur or overlap)
Contributor

flodolo commented Feb 24, 2014

PR updated and tested on OS X, Windows 8 and Linux.

Contributor

flodolo commented Feb 24, 2014

We got the Hungarian slogan, I'll look into it in a few minutes and update the PR if necessary

Contributor

flodolo commented Feb 24, 2014

Proposed slogan for hu fits with the standard font size (80px).

schermata 2014-02-24 alle 16 59 03

@jpetto r?

Member

jpetto commented Feb 24, 2014

Looking good. r+!

jpetto added a commit that referenced this pull request Feb 24, 2014

Merge pull request #1726 from flodolo/bug974803_el_zhTW
Bug 974803 - MWC Partners page: improve display for locales

@jpetto jpetto merged commit b15f552 into mozilla:master Feb 24, 2014

1 check passed

default Jenkins build 'bedrock_github' #3292 has succeeded
Details

@flodolo flodolo deleted the flodolo:bug974803_el_zhTW branch Feb 24, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment